Add multi-level undo/redo functions to Bookmark Manager Private API.

Add multi-level undo/redo functions to Bookmark Manager Private API.

New methods to perform an undo and redo of bookmark changes, as well as
obtaining i18n labels and whether there are actually changes to undo or
redo.

undo()
redo()
getUndoInfo()
getRedoInfo()

This commit is only one part of a multi-level undo/redo system for the
bookmark model and there will be an additional commit to take advantage
of these new function in the bmm.

BUG=126092
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243613

[Tom Cassiotis, 2013-12-20 21:47:32]

Erik would you be able to look at this change?

[arv (Not doing code reviews), 2014-01-06 15:26:44]

LGTM

Pretty straight forward.

Adding Matt so that they are aware of the extension changes.

https://codereview.chromium.org/119233004/diff/1/chrome/browser/extensions/ap...
File
chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
(right):

https://codereview.chromium.org/119233004/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc:592:
Redo();
wrong indentation

https://codereview.chromium.org/119233004/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc:616:
BookmarkUndoServiceFactory::GetForProfile(GetProfile())->undo_manager();
indentation

[Matt Perry, 2014-01-06 19:21:43]

lgtm

[Tom Cassiotis, 2014-01-06 23:28:20]

https://codereview.chromium.org/119233004/diff/1/chrome/browser/extensions/ap...
File
chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
(right):

https://codereview.chromium.org/119233004/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc:592:
Redo();
On 2014/01/06 15:26:45, arv wrote:
> wrong indentation

Done.

https://codereview.chromium.org/119233004/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc:616:
BookmarkUndoServiceFactory::GetForProfile(GetProfile())->undo_manager();
On 2014/01/06 15:26:45, arv wrote:
> indentation

Done.

[commit-bot: I haz the power, 2014-01-06 23:30:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tom.cassiotis@gmail.com/119233004/90001

[commit-bot: I haz the power, 2014-01-06 23:48:23]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Tom Cassiotis, 2014-01-07 00:14:46]

On 2014/01/06 23:48:23, I haz the power (commit-bot) wrote:
> Retried try job too often on chromium_presubmit for step(s) presubmit
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

Looks like Matt recently removed himself from OWNERS.

[miket_OOO, 2014-01-07 17:11:24]

One nit. LGTM

https://codereview.chromium.org/119233004/diff/90001/chrome/common/extensions...
File chrome/common/extensions/api/bookmark_manager_private.json (right):

https://codereview.chromium.org/119233004/diff/90001/chrome/common/extensions...
chrome/common/extensions/api/bookmark_manager_private.json:309: "description":
"Perform an undo of the last change to the bookmark model",
The rest of the file's descriptions are in third-person singular ("performs").
Would you mind conforming?

[commit-bot: I haz the power, 2014-01-07 18:43:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tom.cassiotis@gmail.com/119233004/240001

[commit-bot: I haz the power, 2014-01-07 19:53:04]

Retried try job too often on win_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-08 15:18:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tom.cassiotis@gmail.com/119233004/500001

[commit-bot: I haz the power, 2014-01-08 18:47:55]

Change committed as 243613