Issue 1192283003: DevTools: clear pending script to evaluate on load upon page agent being disabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1192283003: DevTools: clear pending script to evaluate on load upon page agent being disabled (Closed)

Created:
4 years, 10 months ago by caseq

Modified:
4 years, 10 months ago

Reviewers:
pfeldman, yurys

CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: clear pending script to evaluate on load upon page agent being disabled We're supposed to eval and clear this script upon next navigation, but we're about to miss the next navigation if the agent is disabled, so the script may actually be executed at random moment when agent is re-enabled, unless we nuke it upon disable. BUG=501775 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197463

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	Source/core/inspector/InspectorPageAgent.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192283003/1

4 years, 10 months ago (2015-06-19 10:21:39 UTC) #5

commit-bot: I haz the power

4 years, 10 months ago (2015-06-19 11:32:22 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197463

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages