Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1148)

Issue 1192263002: Create xxxhdpi density splits when density splits are enabled (Closed)

Created:
5 years, 6 months ago by agrieve
Modified:
5 years, 6 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create xxxhdpi density splits when density splits are enabled The xxxhdpi density was missed in the initial implementation of density splits. BUG=488324 Committed: https://crrev.com/aa50092a84c19942281fbf8f3a7dc1d67e9a34bb Cr-Commit-Position: refs/heads/master@{#335534}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M build/android/finalize_splits_action.gypi View 1 chunk +3 lines, -1 line 0 comments Download
M build/android/gyp/package_resources.py View 1 chunk +8 lines, -0 lines 0 comments Download
M build/android/package_resources_action.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/device/device_utils.py View 1 2 chunks +2 lines, -1 line 0 comments Download
M build/config/android/internal_rules.gni View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/java_apk.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
agrieve
5 years, 6 months ago (2015-06-19 02:17:36 UTC) #2
cjhopman
lgtm
5 years, 6 months ago (2015-06-19 22:58:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192263002/1
5 years, 6 months ago (2015-06-19 23:43:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/65160) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 6 months ago (2015-06-19 23:49:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192263002/20001
5 years, 6 months ago (2015-06-22 16:45:46 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-22 18:50:38 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 18:51:30 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aa50092a84c19942281fbf8f3a7dc1d67e9a34bb
Cr-Commit-Position: refs/heads/master@{#335534}

Powered by Google App Engine
This is Rietveld 408576698