Merge libchrome_staging target into browser.

Merge libchrome_staging target into browser.

This also merges staging_jni_headers into chrome_browser_jni_headers
and chrome_staging_unittests into unit_tests.

BUG=501140
R=bengr@chromium.org, yfriedman@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/5abd2d6587f7e27e0aee9ff08f2f117360b39393

[newt (away), 2015-06-19 01:24:58]

newt@chromium.org changed reviewers:
+ yfriedmanc@chromium.org

[newt (away), 2015-06-19 01:24:58]

PTAL

[newt (away), 2015-06-19 02:06:23]

newt@chromium.org changed reviewers:
+ bengr@chromium.org, yfriedman@chromium.org
- yfriedmanc@chromium.org

[newt (away), 2015-06-19 02:06:23]

PTAL

https://codereview.chromium.org/1192233002/diff/20001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/1192233002/diff/20001/chrome/chrome_browser.g...
chrome/chrome_browser.gypi:2444:
'browser/android/spdy_proxy_resource_throttle.cc',
bengr: where should these source files be listed? Also, should these files live
in browser/android or browser/safe_browsing?

[newt (away), 2015-06-19 02:08:18]

+pkotwicz FYI

[newt (away), 2015-06-19 02:10:29]

The CQ bit was checked by newt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-19 02:11:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1192233002/20001

[commit-bot: I haz the power, 2015-06-19 03:07:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-19 03:07:04]

Dry run: This issue passed the CQ dry run.

[Yaron, 2015-06-19 13:53:58]

lgtm

https://codereview.chromium.org/1192233002/diff/20001/chrome/android/chrome_a...
File chrome/android/chrome_apk.gyp (right):

https://codereview.chromium.org/1192233002/diff/20001/chrome/android/chrome_a...
chrome/android/chrome_apk.gyp:41: 'java_in_dir': '<(chrome_java_dir)',
I think this is evidence of poor test coverage. You've moved the c++ filers into
the browser target but not java. That means that the unit_tests suite has the
c++ but not corresponding jni bindings. I'm fine with this as an interim step
(esp since you'll be moving java over next) but I don't think this logically
should work.

[newt (away), 2015-06-19 16:47:07]

bengr: Could you take a look at the comment in chrome_browser.gypi about
spdy_proxy_resource_throttle.cc? Thanks!

https://codereview.chromium.org/1192233002/diff/20001/chrome/android/chrome_a...
File chrome/android/chrome_apk.gyp (right):

https://codereview.chromium.org/1192233002/diff/20001/chrome/android/chrome_a...
chrome/android/chrome_apk.gyp:41: 'java_in_dir': '<(chrome_java_dir)',
On 2015/06/19 13:53:58, Yaron wrote:
> I think this is evidence of poor test coverage. You've moved the c++ filers
into
> the browser target but not java. That means that the unit_tests suite has the
> c++ but not corresponding jni bindings. I'm fine with this as an interim step
> (esp since you'll be moving java over next) but I don't think this logically
> should work.

Yeah. I guess the C++ files I've moved are tested only via Java instrumentation
tests, if at all.

[bengr, 2015-06-22 20:50:29]

https://codereview.chromium.org/1192233002/diff/20001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/1192233002/diff/20001/chrome/chrome_browser.g...
chrome/chrome_browser.gypi:2444:
'browser/android/spdy_proxy_resource_throttle.cc',
On 2015/06/19 02:06:23, newt wrote:
> bengr: where should these source files be listed? Also, should these files
live
> in browser/android or browser/safe_browsing?

Good question. This is code that was written for Android, but that could be used
by any platform, but probably won't be.

browser/safe_browsing and browser/net/spdyproxy seem like ok places, the latter
is where we've been dumping things so it's preferred slightly.

References to spdy_proxy should probably be changed to data_reduction_proxy.

[newt (away), 2015-06-22 21:06:19]

newt@chromium.org changed reviewers:
+ sgurun@chromium.org

[newt (away), 2015-06-22 21:06:20]

+sgurun: Could you provide some guidance on where
spdy_proxy_resource_throttle.cc should live and how it should be included in the
GYP file?

[newt (away), 2015-06-22 21:27:16]

I'm going to tackle getting spdy_proxy_resource_throttle.cc just right in a
separate CL, since it turns out to be non-trivial and it can happen in parallel
with other upstreaming work.

[newt (away), 2015-06-22 21:27:52]

The CQ bit was checked by newt@chromium.org

[newt (away), 2015-06-22 21:27:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/1192233002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-06-22 21:29:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1192233002/40001

[sgurun-gerrit only, 2015-06-22 21:33:43]

On 2015/06/22 21:29:05, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1192233002/40001

@newt: it is android specific, but since it is similar to
safe_browsing_resource_throttle.cc it can live next to it, (and now the code is
public, some number of cleanup is possible).

agreed with bengr

[bengr, 2015-06-22 22:04:05]

lgtm, btw.

[commit-bot: I haz the power, 2015-06-22 22:17:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-22 22:17:13]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[newt (away), 2015-06-22 23:47:34]

The CQ bit was checked by newt@chromium.org

[commit-bot: I haz the power, 2015-06-22 23:48:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1192233002/40001

[commit-bot: I haz the power, 2015-06-23 00:32:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-23 00:32:39]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[newt (away), 2015-06-23 01:03:24]

Committed patchset #3 (id:40001) manually as
5abd2d6587f7e27e0aee9ff08f2f117360b39393 (presubmit successful).