Source/platform/fonts/shaping/HarfBuzzFace.cpp - Issue 1192223002: Optimize Complex Text Shaping and Caching

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/shaping/HarfBuzzFace.cpp

Issue 1192223002: Optimize Complex Text Shaping and Caching (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Addressing review comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/fonts/shaping/HarfBuzzFace.cpp

diff --git a/Source/platform/fonts/shaping/HarfBuzzFace.cpp b/Source/platform/fonts/shaping/HarfBuzzFace.cpp

index b30d14beff01c9c11bb1d84bd1762386de636ea4..4639db85b37408f8c0c543b3ab39f623a660744b 100644

--- a/Source/platform/fonts/shaping/HarfBuzzFace.cpp

+++ b/Source/platform/fonts/shaping/HarfBuzzFace.cpp

@@ -357,7 +357,7 @@ hb_face_t* HarfBuzzFace::createFace()

return face;

}

-hb_font_t* HarfBuzzFace::createFont()

+hb_font_t* HarfBuzzFace::createFont() const

{

HarfBuzzFontData* hbFontData = new HarfBuzzFontData(m_glyphCacheForFaceCacheEntry, m_face);

m_platformData->setupPaint(&hbFontData->m_paint);