Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1192203002: Revert of Switch to glyphs as paths at a higher point size on Android (Closed)

Created:
5 years, 6 months ago by f(malita)
Modified:
5 years, 6 months ago
Reviewers:
joshualitt, jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Switch to glyphs as paths at a higher point size on Android (patchset #1 id:1 of https://codereview.chromium.org/1183053005/) Reason for revert: GM:mixedtextblobs looks significantly worse on Android. Before: https://gold.skia.org/img/images/19d171dd72ba68df9501736dbbc2aa44.png After: https://gold.skia.org/img/images/d4c38072d2836356c00fdc1a7b537350.png Original issue's description: > Switch to glyphs as paths at a higher point size on Android > > The regression occurred when we dropped the maximum DF size from 192 > to 162, which meant that any glyph > 324 ended up being rendered as paths > rather than the previous > 384. This pushes the threshold for > rendering paths up to 384. Quality looks fine on high-res devices > which is why this is restricted to Android-only (low-res Android devices > should only rarely have text that large). > > BUG=chromium:467569 > > Committed: https://skia.googlesource.com/skia/+/932d413e69845989fadaecf5bcb8686ec8c05032 TBR=joshualitt@google.com,jvanverth@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:467569 Committed: https://skia.googlesource.com/skia/+/9aa9e716ecba6f62b7ab3f9626f790dce96e61a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M src/gpu/GrAtlasTextContext.cpp View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
f(malita)
Created Revert of Switch to glyphs as paths at a higher point size on Android
5 years, 6 months ago (2015-06-18 21:34:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192203002/1
5 years, 6 months ago (2015-06-18 21:34:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/9aa9e716ecba6f62b7ab3f9626f790dce96e61a5
5 years, 6 months ago (2015-06-18 21:34:59 UTC) #3
jvanverth1
5 years, 6 months ago (2015-06-19 01:07:34 UTC) #4
Message was sent while issue was closed.
On 2015/06/18 21:34:59, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
> https://skia.googlesource.com/skia/+/9aa9e716ecba6f62b7ab3f9626f790dce96e61a5

Which Android bots in particular looked worse?

Powered by Google App Engine
This is Rietveld 408576698