Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Issue 1192153002: [es6] fix IsConcatSpreadable() algorithm in runtime-array.cc (Closed)

Created:
5 years, 6 months ago by caitp (gmail)
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] fix IsConcatSpreadable() algorithm in runtime-array.cc The ordering of the "IsArray()" check for IsConcatSpreadable() was incorrect previously --- IsArray() is only used if Get(O, @@isConcatSpreadable) is undefined. Without this fix, it's not possible for Array subclasses to opt out of spreading 22.1.3.1.1 http://www.ecma-international.org/ecma-262/6.0/#sec-isconcatspreadable BUG=v8:3764 LOG=N R=arv@chromium.org, dslomov@chromium.org, rossberg@chromium.org Committed: https://crrev.com/e7d4bf87adcd32da163d8c6a5af82246f4f83edc Cr-Commit-Position: refs/heads/master@{#29127}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -3 lines) Patch
M src/runtime/runtime-array.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M test/mjsunit/harmony/array-concat.js View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
caitp (gmail)
PTAL, quick fixup following allen's comment on https://esdiscuss.org/topic/isconcatspreadable
5 years, 6 months ago (2015-06-18 15:51:51 UTC) #1
arv (Not doing code reviews)
LGTM Can you change the link to point to the official HTML version instead of ...
5 years, 6 months ago (2015-06-18 17:05:04 UTC) #2
caitp (gmail)
On 2015/06/18 17:05:04, arv wrote: > LGTM > > Can you change the link to ...
5 years, 6 months ago (2015-06-18 17:09:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192153002/1
5 years, 6 months ago (2015-06-18 17:09:44 UTC) #5
caitp (gmail)
On 2015/06/18 17:09:15, caitp wrote: > done. Landing asap since I think the bit got ...
5 years, 6 months ago (2015-06-18 17:10:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-18 19:47:31 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 19:47:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7d4bf87adcd32da163d8c6a5af82246f4f83edc
Cr-Commit-Position: refs/heads/master@{#29127}

Powered by Google App Engine
This is Rietveld 408576698