Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1192143002: Service Worker: Use auto / range-based loop for container objects. (Closed)

Created:
5 years, 6 months ago by jungkees
Modified:
5 years, 6 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Service Worker: Use auto / range-based loop for container objects. - Simplify for-loop in service_worker_storage.cc using auto / range-based loop. This CL is a follow-up on https://codereview.chromium.org/1146913004/#msg59. - Rename a variable name of RegistrationList type to align it to the other names in the file. BUG=N/A Committed: https://crrev.com/ae3e369d08af8d272c0c4f1659762a5e4c39711d Cr-Commit-Position: refs/heads/master@{#335142}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -57 lines) Patch
M content/browser/service_worker/service_worker_storage.cc View 11 chunks +39 lines, -57 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jungkees
PTAL
5 years, 6 months ago (2015-06-18 14:57:27 UTC) #2
kinuko
lgtm
5 years, 6 months ago (2015-06-18 19:47:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192143002/1
5 years, 6 months ago (2015-06-18 21:05:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-18 22:12:39 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 22:13:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae3e369d08af8d272c0c4f1659762a5e4c39711d
Cr-Commit-Position: refs/heads/master@{#335142}

Powered by Google App Engine
This is Rietveld 408576698