Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Side by Side Diff: runtime/vm/intermediate_language_x64.cc

Issue 119213002: Use parallel move resolver for optimized try-catch. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language_mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_X64.
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 1170 matching lines...) Expand 10 before | Expand all | Expand 10 after
1181 Register field_reg = needs_field_temp_reg ? 1181 Register field_reg = needs_field_temp_reg ?
1182 locs()->temp(locs()->temp_count() - 1).reg() : kNoRegister; 1182 locs()->temp(locs()->temp_count() - 1).reg() : kNoRegister;
1183 1183
1184 Label ok, fail_label; 1184 Label ok, fail_label;
1185 1185
1186 Label* deopt = compiler->is_optimizing() ? 1186 Label* deopt = compiler->is_optimizing() ?
1187 compiler->AddDeoptStub(deopt_id(), kDeoptGuardField) : NULL; 1187 compiler->AddDeoptStub(deopt_id(), kDeoptGuardField) : NULL;
1188 1188
1189 Label* fail = (deopt != NULL) ? deopt : &fail_label; 1189 Label* fail = (deopt != NULL) ? deopt : &fail_label;
1190 1190
1191 const bool ok_is_fall_through = (deopt != NULL);
1192
1193 if (!compiler->is_optimizing() || (field_cid == kIllegalCid)) { 1191 if (!compiler->is_optimizing() || (field_cid == kIllegalCid)) {
1194 if (!compiler->is_optimizing() && (field_reg == kNoRegister)) { 1192 if (!compiler->is_optimizing() && (field_reg == kNoRegister)) {
1195 // Currently we can't have different location summaries for optimized 1193 // Currently we can't have different location summaries for optimized
1196 // and non-optimized code. So instead we manually pick up a register 1194 // and non-optimized code. So instead we manually pick up a register
1197 // that is known to be free because we know how non-optimizing compiler 1195 // that is known to be free because we know how non-optimizing compiler
1198 // allocates registers. 1196 // allocates registers.
1199 field_reg = RBX; 1197 field_reg = RBX;
1200 ASSERT((field_reg != value_reg) && (field_reg != value_cid_reg)); 1198 ASSERT((field_reg != value_reg) && (field_reg != value_cid_reg));
1201 } 1199 }
1202 1200
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
1380 // Destroy value_cid_reg (safe because we are finished with it). 1378 // Destroy value_cid_reg (safe because we are finished with it).
1381 __ movq(value_cid_reg, 1379 __ movq(value_cid_reg,
1382 FieldAddress(value_reg, TypedData::length_offset())); 1380 FieldAddress(value_reg, TypedData::length_offset()));
1383 __ movq(field_length_operand, value_cid_reg); 1381 __ movq(field_length_operand, value_cid_reg);
1384 } else { 1382 } else {
1385 __ LoadImmediate(field_length_operand, 1383 __ LoadImmediate(field_length_operand,
1386 Immediate(Smi::RawValue(Field::kNoFixedLength)), PP); 1384 Immediate(Smi::RawValue(Field::kNoFixedLength)), PP);
1387 } 1385 }
1388 } 1386 }
1389 } 1387 }
1390 if (!ok_is_fall_through) {
1391 __ jmp(&ok);
1392 }
1393 1388
1394 if (deopt == NULL) { 1389 if (deopt == NULL) {
1395 ASSERT(!compiler->is_optimizing()); 1390 ASSERT(!compiler->is_optimizing());
1391 __ jmp(&ok);
1396 __ Bind(fail); 1392 __ Bind(fail);
1397 1393
1398 __ CompareImmediate(FieldAddress(field_reg, Field::guarded_cid_offset()), 1394 __ CompareImmediate(FieldAddress(field_reg, Field::guarded_cid_offset()),
1399 Immediate(kDynamicCid), PP); 1395 Immediate(kDynamicCid), PP);
1400 __ j(EQUAL, &ok); 1396 __ j(EQUAL, &ok);
1401 1397
1402 __ pushq(field_reg); 1398 __ pushq(field_reg);
1403 __ pushq(value_reg); 1399 __ pushq(value_reg);
1404 __ CallRuntime(kUpdateFieldCidRuntimeEntry, 2); 1400 __ CallRuntime(kUpdateFieldCidRuntimeEntry, 2);
1405 __ Drop(2); // Drop the field and the value. 1401 __ Drop(2); // Drop the field and the value.
1406 } 1402 }
1407 } else { 1403 } else {
1408 ASSERT(compiler->is_optimizing()); 1404 ASSERT(compiler->is_optimizing());
1409 ASSERT(deopt != NULL); 1405 ASSERT(deopt != NULL);
1410 ASSERT(ok_is_fall_through);
1411 // Field guard class has been initialized and is known. 1406 // Field guard class has been initialized and is known.
1412 if (field_reg != kNoRegister) { 1407 if (field_reg != kNoRegister) {
1413 __ LoadObject(field_reg, Field::ZoneHandle(field().raw()), PP); 1408 __ LoadObject(field_reg, Field::ZoneHandle(field().raw()), PP);
1414 } 1409 }
1415 1410
1416 if (value_cid == kDynamicCid) { 1411 if (value_cid == kDynamicCid) {
1417 // Field's guarded class id is fixed but value's class id is not known. 1412 // Field's guarded class id is fixed but value's class id is not known.
1418 __ testq(value_reg, Immediate(kSmiTagMask)); 1413 __ testq(value_reg, Immediate(kSmiTagMask));
1419 1414
1420 if (field_cid != kSmiCid) { 1415 if (field_cid != kSmiCid) {
(...skipping 3518 matching lines...) Expand 10 before | Expand all | Expand 10 after
4939 PcDescriptors::kOther, 4934 PcDescriptors::kOther,
4940 locs()); 4935 locs());
4941 __ Drop(2); // Discard type arguments and receiver. 4936 __ Drop(2); // Discard type arguments and receiver.
4942 } 4937 }
4943 4938
4944 } // namespace dart 4939 } // namespace dart
4945 4940
4946 #undef __ 4941 #undef __
4947 4942
4948 #endif // defined TARGET_ARCH_X64 4943 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698