Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: runtime/vm/intermediate_language_arm.cc

Issue 119213002: Use parallel move resolver for optimized try-catch. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM.
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 1282 matching lines...) Expand 10 before | Expand all | Expand 10 after
1293 Register field_reg = needs_field_temp_reg ? 1293 Register field_reg = needs_field_temp_reg ?
1294 locs()->temp(locs()->temp_count() - 1).reg() : kNoRegister; 1294 locs()->temp(locs()->temp_count() - 1).reg() : kNoRegister;
1295 1295
1296 Label ok, fail_label; 1296 Label ok, fail_label;
1297 1297
1298 Label* deopt = compiler->is_optimizing() ? 1298 Label* deopt = compiler->is_optimizing() ?
1299 compiler->AddDeoptStub(deopt_id(), kDeoptGuardField) : NULL; 1299 compiler->AddDeoptStub(deopt_id(), kDeoptGuardField) : NULL;
1300 1300
1301 Label* fail = (deopt != NULL) ? deopt : &fail_label; 1301 Label* fail = (deopt != NULL) ? deopt : &fail_label;
1302 1302
1303 const bool ok_is_fall_through = (deopt != NULL);
1304
1305 if (!compiler->is_optimizing() || (field_cid == kIllegalCid)) { 1303 if (!compiler->is_optimizing() || (field_cid == kIllegalCid)) {
1306 if (!compiler->is_optimizing() && (field_reg == kNoRegister)) { 1304 if (!compiler->is_optimizing() && (field_reg == kNoRegister)) {
1307 // Currently we can't have different location summaries for optimized 1305 // Currently we can't have different location summaries for optimized
1308 // and non-optimized code. So instead we manually pick up a register 1306 // and non-optimized code. So instead we manually pick up a register
1309 // that is known to be free because we know how non-optimizing compiler 1307 // that is known to be free because we know how non-optimizing compiler
1310 // allocates registers. 1308 // allocates registers.
1311 field_reg = R2; 1309 field_reg = R2;
1312 ASSERT((field_reg != value_reg) && (field_reg != value_cid_reg)); 1310 ASSERT((field_reg != value_reg) && (field_reg != value_cid_reg));
1313 } 1311 }
1314 1312
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
1479 // Destroy value_cid_reg (safe because we are finished with it). 1477 // Destroy value_cid_reg (safe because we are finished with it).
1480 __ ldr(value_cid_reg, 1478 __ ldr(value_cid_reg,
1481 FieldAddress(value_reg, TypedData::length_offset())); 1479 FieldAddress(value_reg, TypedData::length_offset()));
1482 __ str(value_cid_reg, field_length_operand); 1480 __ str(value_cid_reg, field_length_operand);
1483 } else { 1481 } else {
1484 __ LoadImmediate(IP, Smi::RawValue(Field::kNoFixedLength)); 1482 __ LoadImmediate(IP, Smi::RawValue(Field::kNoFixedLength));
1485 __ str(IP, field_length_operand); 1483 __ str(IP, field_length_operand);
1486 } 1484 }
1487 } 1485 }
1488 } 1486 }
1489 if (!ok_is_fall_through) {
1490 __ b(&ok);
1491 }
1492 1487
1493 if (deopt == NULL) { 1488 if (deopt == NULL) {
1494 ASSERT(!compiler->is_optimizing()); 1489 ASSERT(!compiler->is_optimizing());
1490 __ b(&ok);
1495 __ Bind(fail); 1491 __ Bind(fail);
1496 1492
1497 __ ldr(IP, FieldAddress(field_reg, Field::guarded_cid_offset())); 1493 __ ldr(IP, FieldAddress(field_reg, Field::guarded_cid_offset()));
1498 __ CompareImmediate(IP, kDynamicCid); 1494 __ CompareImmediate(IP, kDynamicCid);
1499 __ b(&ok, EQ); 1495 __ b(&ok, EQ);
1500 1496
1501 __ Push(field_reg); 1497 __ Push(field_reg);
1502 __ Push(value_reg); 1498 __ Push(value_reg);
1503 __ CallRuntime(kUpdateFieldCidRuntimeEntry, 2); 1499 __ CallRuntime(kUpdateFieldCidRuntimeEntry, 2);
1504 __ Drop(2); // Drop the field and the value. 1500 __ Drop(2); // Drop the field and the value.
1505 } 1501 }
1506 } else { 1502 } else {
1507 ASSERT(compiler->is_optimizing()); 1503 ASSERT(compiler->is_optimizing());
1508 ASSERT(deopt != NULL); 1504 ASSERT(deopt != NULL);
1509 ASSERT(ok_is_fall_through);
1510 // Field guard class has been initialized and is known. 1505 // Field guard class has been initialized and is known.
1511 if (field_reg != kNoRegister) { 1506 if (field_reg != kNoRegister) {
1512 __ LoadObject(field_reg, Field::ZoneHandle(field().raw())); 1507 __ LoadObject(field_reg, Field::ZoneHandle(field().raw()));
1513 } 1508 }
1514 if (value_cid == kDynamicCid) { 1509 if (value_cid == kDynamicCid) {
1515 // Field's guarded class id is fixed by value's class id is not known. 1510 // Field's guarded class id is fixed by value's class id is not known.
1516 __ tst(value_reg, ShifterOperand(kSmiTagMask)); 1511 __ tst(value_reg, ShifterOperand(kSmiTagMask));
1517 1512
1518 if (field_cid != kSmiCid) { 1513 if (field_cid != kSmiCid) {
1519 __ b(fail, EQ); 1514 __ b(fail, EQ);
(...skipping 3300 matching lines...) Expand 10 before | Expand all | Expand 10 after
4820 compiler->GenerateCall(token_pos(), 4815 compiler->GenerateCall(token_pos(),
4821 &label, 4816 &label,
4822 PcDescriptors::kOther, 4817 PcDescriptors::kOther,
4823 locs()); 4818 locs());
4824 __ Drop(2); // Discard type arguments and receiver. 4819 __ Drop(2); // Discard type arguments and receiver.
4825 } 4820 }
4826 4821
4827 } // namespace dart 4822 } // namespace dart
4828 4823
4829 #endif // defined TARGET_ARCH_ARM 4824 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language.h ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698