Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Unified Diff: runtime/vm/instructions_mips.h

Issue 1192103004: VM: New calling convention for generated code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: fixed comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/instructions_ia32_test.cc ('k') | runtime/vm/instructions_mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/instructions_mips.h
diff --git a/runtime/vm/instructions_mips.h b/runtime/vm/instructions_mips.h
index 51875b5194e0facd1ebb2d4d885369274ad469ae..d3e784d66301d51f07a75d4852b09e2372a9501f 100644
--- a/runtime/vm/instructions_mips.h
+++ b/runtime/vm/instructions_mips.h
@@ -54,14 +54,12 @@ class CallPattern : public ValueObject {
RawICData* IcData();
- uword TargetAddress() const;
- void SetTargetAddress(uword target_address) const;
+ RawCode* TargetCode() const;
+ void SetTargetCode(const Code& target) const;
- // This constant length is only valid for inserted call patterns used for
- // lazy deoptimization. Regular call pattern may vary in length.
- static const int kFixedLengthInBytes = 4 * Instr::kInstrSize;
+ static const int kDeoptCallLengthInBytes = 4 * Instr::kInstrSize;
- static void InsertAt(uword pc, uword target_address);
+ static void InsertDeoptCallAt(uword pc, uword target_address);
private:
const ObjectPool& object_pool_;
@@ -69,7 +67,7 @@ class CallPattern : public ValueObject {
uword end_;
uword ic_data_load_end_;
- intptr_t target_address_pool_index_;
+ intptr_t target_code_pool_index_;
ICData& ic_data_;
DISALLOW_COPY_AND_ASSIGN(CallPattern);
@@ -80,8 +78,8 @@ class NativeCallPattern : public ValueObject {
public:
NativeCallPattern(uword pc, const Code& code);
- uword target() const;
- void set_target(uword target_address) const;
+ RawCode* target() const;
+ void set_target(const Code& target) const;
NativeFunction native_function() const;
void set_native_function(NativeFunction target) const;
@@ -91,34 +89,12 @@ class NativeCallPattern : public ValueObject {
uword end_;
intptr_t native_function_pool_index_;
- intptr_t target_address_pool_index_;
+ intptr_t target_code_pool_index_;
DISALLOW_COPY_AND_ASSIGN(NativeCallPattern);
};
-class JumpPattern : public ValueObject {
- public:
- JumpPattern(uword pc, const Code& code);
-
- // lui; ori; jr; nop (in delay slot) = 4.
- static const int kLengthInBytes = 4*Instr::kInstrSize;
-
- int pattern_length_in_bytes() const {
- return kLengthInBytes;
- }
-
- bool IsValid() const;
- uword TargetAddress() const;
- void SetTargetAddress(uword target_address) const;
-
- private:
- const uword pc_;
-
- DISALLOW_COPY_AND_ASSIGN(JumpPattern);
-};
-
-
class ReturnPattern : public ValueObject {
public:
explicit ReturnPattern(uword pc);
« no previous file with comments | « runtime/vm/instructions_ia32_test.cc ('k') | runtime/vm/instructions_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698