runtime/vm/debugger.h - Issue 1192103004: VM: New calling convention for generated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/debugger.h

Issue 1192103004: VM: New calling convention for generated code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: fixed comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/debugger.h

diff --git a/runtime/vm/debugger.h b/runtime/vm/debugger.h

index 685e5b5714a6324b949a728360eb262805ca95b8..cf6562ad18ca29ffd48e941c5c1edf1ec6cf2e4c 100644

--- a/runtime/vm/debugger.h

+++ b/runtime/vm/debugger.h

@@ -191,7 +191,7 @@ class CodeBreakpoint {

void Disable();

bool IsEnabled() const { return is_enabled_; }

- uword OrigStubAddress() const;

+ RawCode* OrigStubAddress() const;

private:

void VisitObjectPointers(ObjectPointerVisitor* visitor);

@@ -215,7 +215,7 @@ class CodeBreakpoint {

CodeBreakpoint* next_;

RawPcDescriptors::Kind breakpoint_kind_;

- uword saved_value_;

+ RawCode* saved_value_;

friend class Debugger;

DISALLOW_COPY_AND_ASSIGN(CodeBreakpoint);

@@ -565,7 +565,7 @@ class Debugger {

void SignalIsolateEvent(DebuggerEvent::EventType type);

static void SignalIsolateInterrupted();

- uword GetPatchedStubAddress(uword breakpoint_address);

+ RawCode* GetPatchedStubAddress(uword breakpoint_address);

void PrintBreakpointsToJSONArray(JSONArray* jsarr) const;

void PrintSettingsToJSONObject(JSONObject* jsobj) const;

« no previous file with comments | « runtime/vm/dart_entry.cc ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »