Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: runtime/vm/object_x64_test.cc

Issue 1192103004: VM: New calling convention for generated code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/object_x64_test.cc
diff --git a/runtime/vm/object_x64_test.cc b/runtime/vm/object_x64_test.cc
index b8914e0ab274737fe76e98587356b2b350e61f05..87727b773233bc327acc1930d433a6a1185b9c5c 100644
--- a/runtime/vm/object_x64_test.cc
+++ b/runtime/vm/object_x64_test.cc
@@ -34,10 +34,14 @@ void GenerateIncrement(Assembler* assembler) {
void GenerateEmbedStringInCode(Assembler* assembler, const char* str) {
const String& string_object =
String::ZoneHandle(String::New(str, Heap::kOld));
+ __ pushq(CODE_REG);
__ pushq(PP); // Save caller's pool pointer and load a new one here.
+ __ movq(CODE_REG, Address(CallingConventions::kArg1Reg,
+ VMHandles::kOffsetOfRawPtrInHandle));
__ LoadPoolPointer(PP);
__ LoadObject(RAX, string_object, PP);
__ popq(PP); // Restore caller's pool pointer.
+ __ popq(CODE_REG);
__ ret();
}

Powered by Google App Engine
This is Rietveld 408576698