runtime/vm/intrinsifier_x64.cc - Issue 1192103004: VM: New calling convention for generated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intrinsifier_x64.cc

Issue 1192103004: VM: New calling convention for generated code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/intrinsifier_x64.cc

diff --git a/runtime/vm/intrinsifier_x64.cc b/runtime/vm/intrinsifier_x64.cc

index 14eb3cf88885901d1df596bb213f4f46d3c760dc..6195a72a9713755f78de9d5bceadf89002e24313 100644

--- a/runtime/vm/intrinsifier_x64.cc

+++ b/runtime/vm/intrinsifier_x64.cc

@@ -1936,7 +1936,8 @@ void Intrinsifier::JSRegExp_ExecuteMatch(Assembler* assembler) {

__ xorq(RCX, RCX);

// Tail-call the function.

- __ movq(RDI, FieldAddress(RAX, Function::instructions_offset()));

+ __ movq(CODE_REG, FieldAddress(RAX, Function::code_offset()));

+ __ movq(RDI, FieldAddress(CODE_REG, Code::instructions_offset()));

__ addq(RDI, Immediate(Instructions::HeaderSize() - kHeapObjectTag));

__ jmp(RDI);

}