pkg/compiler/lib/src/constants/constructors.dart - Issue 1192103002: Support serialization of the compiler backbone.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/constants/constructors.dart

Issue 1192103002: Support serialization of the compiler backbone. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Handle (bypass) external const constructors. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/constants/constructors.dart

diff --git a/pkg/compiler/lib/src/constants/constructors.dart b/pkg/compiler/lib/src/constants/constructors.dart

index a92edcccf186006216f034b23ae4cbeea354e007..1e588a85afd7f42c06681cf6158a37a28fd7d9a2 100644

--- a/pkg/compiler/lib/src/constants/constructors.dart

+++ b/pkg/compiler/lib/src/constants/constructors.dart

@@ -135,7 +135,7 @@ class ConstantConstructorComputer extends SemanticVisitor

NodeList parameters,

Node body, _) {

// TODO(johnniwinther): Handle constant constructors with errors.

- internalError(node, "Factory constructor cannot be constant.");

+ internalError(node, "Factory constructor cannot be constant: $node.");

}

applyParameters(NodeList parameters, _) {

« no previous file with comments | « pkg/compiler/lib/src/compiler.dart ('k') | pkg/compiler/lib/src/constants/expressions.dart » ('j') | no next file with comments »