Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 1192063002: [turbofan] Improve interplay of ControlReducer and CommonOperatorReducer. (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Improve interplay of ControlReducer and CommonOperatorReducer. This turns the CommonOperatorReducer into an AdvancedReducer and makes it independent of JSGraph (which was used only because it was convienent), and let's the CommonOperatorReducer run together with the ControlReducer. The ControlReducer is still not able to run together with other reducers, but we're getting closer. The plan is to split the ControlReducer into two parts: The dead code elimination part and the common operator reduction part. This separation will help to avoid tricky bugs in the future and should make testing a *lot* easier. R=jarin@chromium.org Committed: https://crrev.com/92e6bcf13c2c9834e1d45930a3f6442a3a0feb87 Cr-Commit-Position: refs/heads/master@{#29105}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -420 lines) Patch
M src/compiler/common-operator-reducer.h View 2 chunks +14 lines, -8 lines 0 comments Download
M src/compiler/common-operator-reducer.cc View 4 chunks +65 lines, -39 lines 0 comments Download
M src/compiler/control-reducer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/control-reducer.cc View 5 chunks +4 lines, -47 lines 0 comments Download
M src/compiler/pipeline.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M test/cctest/compiler/test-control-reducer.cc View 3 chunks +0 lines, -299 lines 0 comments Download
M test/unittests/compiler/common-operator-reducer-unittest.cc View 12 chunks +83 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-18 08:42:16 UTC) #1
Benedikt Meurer
Hey Jaro, This is the first step towards dead code elimination (Dead node propagation) as ...
5 years, 6 months ago (2015-06-18 08:43:32 UTC) #2
Benedikt Meurer
... preparation cleanup...
5 years, 6 months ago (2015-06-18 08:53:16 UTC) #3
Jarin
lgtm
5 years, 6 months ago (2015-06-18 09:09:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192063002/1
5 years, 6 months ago (2015-06-18 09:09:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-18 09:15:38 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 09:15:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92e6bcf13c2c9834e1d45930a3f6442a3a0feb87
Cr-Commit-Position: refs/heads/master@{#29105}

Powered by Google App Engine
This is Rietveld 408576698