Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 1192053002: Templatize extractSelectedHTMLAlgorithm used by FrameSelection function (Closed)

Created:
4 years, 10 months ago by hajimehoshi
Modified:
4 years, 10 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Templatize extractSelectedHTMLAlgorithm used by FrameSelection function This patch introduces a template function |extractSelectedHTMLAlgorithm<Strategy>| to makes |extractSelectedText()| function used by |FrameSeleciton| to work both on DOM tree and composed tree via |Strategy| template parameter. This patch is result of collaboration work with yosin@chromium.org for selection of web components. After this patch, we are going to implement another strategies for the composed tree. We've already prepared that at http://crrev.com/1106433002. BUG=275851 TEST=n/a; No behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197335

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M Source/core/editing/FrameSelection.cpp View 1 chunk +12 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
hajimehoshi
PTAL
4 years, 10 months ago (2015-06-18 07:31:36 UTC) #2
yosin_UTC9
I'm OK this patch. Since I'm co-author of this patch, I'm not a good for ...
4 years, 10 months ago (2015-06-18 07:44:34 UTC) #3
tkent
lgtm
4 years, 10 months ago (2015-06-18 07:51:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192053002/1
4 years, 10 months ago (2015-06-18 07:52:04 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2015-06-18 09:49:06 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197335

Powered by Google App Engine
This is Rietveld 408576698