Issue 1192023002: Add buttons to WebInputEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1192023002: Add buttons to WebInputEvent (Closed)

Created:
5 years, 6 months ago by cpu_(ooo_6.6-7.5)

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add buttons to WebInputEvent So we can tell l-click from r-click. BUG=none R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/14d04e988c6be8e5adaeab4346cede9640e0ba67

Patch Set 2 : comments #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
	M	sky/viewer/converters/input_event_types.cc	View	1	2 chunks	+14 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

cpu_(ooo_6.6-7.5)

Not sure this is the best approach but at least I can r-click flag a ...

5 years, 6 months ago (2015-06-18 02:19:36 UTC) #2

abarth-chromium

LGTM https://codereview.chromium.org/1192023002/diff/1/sky/viewer/converters/input_event_types.cc File sky/viewer/converters/input_event_types.cc (right): https://codereview.chromium.org/1192023002/diff/1/sky/viewer/converters/input_event_types.cc#newcode80 sky/viewer/converters/input_event_types.cc:80: buttons |= modifiers & blink::WebInputEvent::RightButtonDown ? 2 : ...

5 years, 6 months ago (2015-06-18 02:24:03 UTC) #3

cpu_(ooo_6.6-7.5)

5 years, 6 months ago (2015-06-18 02:46:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
14d04e988c6be8e5adaeab4346cede9640e0ba67 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 1192023002: Add buttons to WebInputEvent (Closed)

Description

Patch Set 1 #

Patch Set 2 : comments #

Messages