content/browser/service_worker/service_worker_request_handler.cc - Issue 1192013003: [Extension ServiceWorkers] Allow service worker registration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_request_handler.cc

Issue 1192013003: [Extension ServiceWorkers] Allow service worker registration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added comments to test Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_dispatcher_host.cc ('k') | content/browser/service_worker/service_worker_request_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_request_handler.cc

diff --git a/content/browser/service_worker/service_worker_request_handler.cc b/content/browser/service_worker/service_worker_request_handler.cc

index c0b739494a5b8f3a3ed10fd864a42329ca88eb35..e3edcb04c6026dc17db92573b526e01707cf3144 100644

--- a/content/browser/service_worker/service_worker_request_handler.cc

+++ b/content/browser/service_worker/service_worker_request_handler.cc

@@ -15,6 +15,7 @@

#include "content/common/resource_request_body.h"

#include "content/common/service_worker/service_worker_types.h"

#include "content/public/browser/resource_context.h"

+#include "content/public/common/origin_util.h"

#include "net/base/net_util.h"

#include "net/url_request/url_request.h"

#include "net/url_request/url_request_interceptor.h"

@@ -63,7 +64,7 @@ void ServiceWorkerRequestHandler::InitializeHandler(

RequestContextType request_context_type,

RequestContextFrameType frame_type,

scoped_refptr<ResourceRequestBody> body) {

- if (!request->url().SchemeIsHTTPOrHTTPS())

+ if (!OriginCanAccessServiceWorkers(request->url()))

return;

if (!context_wrapper || !context_wrapper->context() ||