chrome/test/data/extensions/api_test/service_worker/register/page.js - Issue 1192013003: [Extension ServiceWorkers] Allow service worker registration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/service_worker/register/page.js

Issue 1192013003: [Extension ServiceWorkers] Allow service worker registration (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added comments to test Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/service_worker/register/page.html ('k') | chrome/test/data/extensions/api_test/service_worker/register/sw.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/service_worker/register/page.js

diff --git a/chrome/test/data/extensions/api_test/service_worker/register/test.js b/chrome/test/data/extensions/api_test/service_worker/register/page.js

similarity index 91%

copy from chrome/test/data/extensions/api_test/service_worker/register/test.js

copy to chrome/test/data/extensions/api_test/service_worker/register/page.js

index 0e3e96efbecac52abe52d87981937c43fbf5c5ea..49633e788d521e19734cccfbffde959df0db609c 100644

--- a/chrome/test/data/extensions/api_test/service_worker/register/test.js

+++ b/chrome/test/data/extensions/api_test/service_worker/register/page.js

@@ -2,7 +2,7 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-var logForDebugging = false;

+var logForDebugging = true;

function log(message) {

if (logForDebugging)

console.log(message);

@@ -14,7 +14,6 @@ chrome.test.runTests([

// Registration was successful

log('ServiceWorker registration successful with scope: ',

registration.scope);

- chrome.test.sendMessage("success");

chrome.test.succeed();

}).catch(function(err) {

// registration failed :(