content/browser/bad_message.cc - Issue 1192003006: Cache Storage: restrict access to secure origins (Chromium-side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/bad_message.cc

Issue 1192003006: Cache Storage: restrict access to secure origins (Chromium-side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Actually try building Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/bad_message.h ('k') | content/browser/cache_storage/cache_storage_dispatcher_host.cc » ('j') | content/browser/cache_storage/cache_storage_dispatcher_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/bad_message.cc

diff --git a/content/browser/bad_message.cc b/content/browser/bad_message.cc

index 975aab1441ce15eb14130b0d0a9eb6ff23a56f71..f7e30368f89b83bab714ea71f2c8c0f220946ad0 100644

--- a/content/browser/bad_message.cc

+++ b/content/browser/bad_message.cc

@@ -5,7 +5,7 @@

#include "content/browser/bad_message.h"

#include "base/logging.h"

-#include "base/metrics/histogram_macros.h"

+#include "base/metrics/sparse_histogram.h"

#include "content/public/browser/browser_message_filter.h"

#include "content/public/browser/render_process_host.h"

@@ -16,8 +16,7 @@ namespace {

void LogBadMessage(BadMessageReason reason) {

LOG(ERROR) << "Terminating renderer for bad IPC message, reason " << reason;

- UMA_HISTOGRAM_ENUMERATION("Stability.BadMessageTerminated.Content", reason,

- BAD_MESSAGE_MAX);

+ UMA_HISTOGRAM_SPARSE_SLOWLY("Stability.BadMessageTerminated.Content", reason);

}

} // namespace