Issue 1192003003: Clean up the tests to be more maintainable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1192003003: Clean up the tests to be more maintainable. (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Clean up the tests to be more maintainable. - removes the unit testing framework from tests that don't use it - use 'async' where that makes the code less convoluted R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4939ed1bc47ee518e035995590d6108aa6bafbee

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -54 lines)			Patch
M	sky/tests/framework/stocks.dart	View	1 chunk	+4 lines, -10 lines	0 comments	Download
M	sky/tests/framework/stocks-expected.txt	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	sky/tests/raw/box_layout.dart	View	1 chunk	+6 lines, -12 lines	0 comments	Download
M	sky/tests/raw/box_layout-expected.txt	View	2 chunks	+1 line, -6 lines	0 comments	Download
M	sky/tests/resources/display_list.dart	View	3 chunks	+9 lines, -5 lines	0 comments	Download
M	sky/tests/widgets/buttons.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/tests/widgets/dialog.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/tests/widgets/syncs1.dart	View	1 chunk	+7 lines, -13 lines	0 comments	Download

Total messages: 3 (1 generated)

Hixie

5 years, 6 months ago (2015-06-17 22:10:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4939ed1bc47ee518e035995590d6108aa6bafbee (presubmit successful).