src/objects.cc - Issue 1191973004: Work In Progress: support new.target

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 1191973004: Work In Progress: support new.target (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 008058894833b5114da05b9cdd3f181ba7216ebe..640ef0d7979fafa613d6b311f80d571a4d1cf36f 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -10565,7 +10565,8 @@ void SharedFunctionInfo::DisableOptimization(BailoutReason reason) {

void SharedFunctionInfo::InitFromFunctionLiteral(

Handle<SharedFunctionInfo> shared_info, FunctionLiteral* lit) {

shared_info->set_length(lit->scope()->default_function_length());

- if (IsSubclassConstructor(lit->kind())) {

+ if (IsSubclassConstructor(lit->kind()) ||

+ lit->scope()->new_target_var() != nullptr) {

shared_info->set_internal_formal_parameter_count(lit->parameter_count() +

1);

} else {