Issue 1191973004: Work In Progress: support new.target

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1191973004: Work In Progress: support new.target (Closed)

Created:
5 years, 6 months ago by arv (Not doing code reviews)

Modified:
5 years, 6 months ago

Reviewers:
adamk

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Work In Progress: support new.target patch from issue 1188383002 at patchset 1 (http://crrev.com/1188383002#ps1)

Patch Set 1 #

Total comments: 3

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+161 lines, -19 lines)			Patch
M	src/builtins.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/compiler.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/objects.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/scopes.cc	View	1 chunk	+8 lines, -12 lines	0 comments	Download
M	src/x64/builtins-x64.cc	View	7 chunks	+28 lines, -3 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	2 chunks	+26 lines, -2 lines	0 comments	Download
A	test/mjsunit/harmony/new-target.js	View	1 chunk	+89 lines, -0 lines	3 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

arv (Not doing code reviews)

5 years, 6 months ago (2015-06-18 22:17:59 UTC) #2

https://codereview.chromium.org/1191973004/diff/1/test/mjsunit/harmony/new-ta...
File test/mjsunit/harmony/new-target.js (right):

https://codereview.chromium.org/1191973004/diff/1/test/mjsunit/harmony/new-ta...
test/mjsunit/harmony/new-target.js:34: f(undefined, 'extra');
This one fails. `expected` ends up as the 'extra'.

https://codereview.chromium.org/1191973004/diff/1/test/mjsunit/harmony/new-ta...
test/mjsunit/harmony/new-target.js:46: new f(f);
This one fails.

https://codereview.chromium.org/1191973004/diff/1/test/mjsunit/harmony/new-ta...
test/mjsunit/harmony/new-target.js:77: new Derived();
This one fails too...

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages