Add useDFT field to SkDeviceProperties

Add useDFT field to SkDeviceProperties

Committed: https://skia.googlesource.com/skia/+/bcd7ab5c0d0e5c3432a9aaeb44f1b703fea94282

[robertphillips, 2015-06-17 15:40:33]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com, jvanverth@google.com

[reed1, 2015-06-17 15:43:31]

reed@google.com changed reviewers:
+ bungeman@google.com, reed@google.com

[reed1, 2015-06-17 15:43:31]

reed@google.com changed required reviewers:
+ bungeman@google.com

[jvanverth1, 2015-06-17 16:05:53]

Looks okay to me, but it sounds like bungeman@ may have some concerns.

[bungeman-skia, 2015-06-17 16:10:08]

Is using distance field text really a property of the entire device? For
example, the subpixel geometry and gamma are properties of the surface/device.
However, exploiting any subpixel geometry is not (the paint still needs a
setting for whether to alias, pixel anti-alias, or subpixel anti-alias). The
device properties seem more like things which cannot vary over the life of the
device. On the other hand, it seems like there's nothing wrong with requesting
that (on the same surface/device) that some text be requested to be drawn with
distance fields, and some not. 

What is the plan for interaction with the surface properties? The device
properties exist for now because that was a high as I could pull these settings
at the time. Once device is actually private, the plan was to merge the device
properties and surface properties and just use the surface properties structure.

[bungeman-skia, 2015-06-17 18:47:24]

A graphics context by any other name would smell as sweet?

In the interest of merging SkDeviceProperties into SkSurfaceProperties and
making SkSurfaceProperties the new name for our graphics context parameters,
lgtm.

[robertphillips, 2015-06-17 19:03:56]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-06-17 19:04:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1191943002/1

[commit-bot: I haz the power, 2015-06-17 19:09:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-17 19:09:47]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2015-06-17 19:14:15]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2015-06-17 19:14:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1191943002/1

[commit-bot: I haz the power, 2015-06-17 19:15:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-17 19:15:36]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[robertphillips, 2015-06-17 19:17:01]

Brian, Mike?

[bsalomon, 2015-06-17 20:10:12]

On 2015/06/17 19:17:01, robertphillips wrote:
> Brian, Mike?

lgtm

[robertphillips, 2015-06-18 11:54:34]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2015-06-18 11:54:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1191943002/1

[commit-bot: I haz the power, 2015-06-18 11:55:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-18 11:55:51]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[robertphillips, 2015-06-18 11:58:39]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2015-06-18 11:58:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1191943002/1

[commit-bot: I haz the power, 2015-06-18 11:59:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-18 11:59:54]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[robertphillips, 2015-06-18 12:21:36]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2015-06-18 12:21:37]

The patchset sent to the CQ was uploaded after l-g-t-m from bungeman@google.com,
bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1191943002/#ps20001
(title: "update to ToT")

[commit-bot: I haz the power, 2015-06-18 12:21:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1191943002/20001

[commit-bot: I haz the power, 2015-06-18 12:27:24]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/bcd7ab5c0d0e5c3432a9aaeb44f1b703fea94282