Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 1191913002: [turbofan] Remove hack for dead nodes from JSGenericLowering. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove hack for dead nodes from JSGenericLowering. Now that the graph is being trimmed after generic lowering, we can drop this workaround. The diamond will no longer confuse the scheduler. R=bmeurer@chromium.org Committed: https://crrev.com/25e687965fdc380b722712b45716ce1a6db79e3b Cr-Commit-Position: refs/heads/master@{#29081}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M src/compiler/js-generic-lowering.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 6 months ago (2015-06-17 11:04:34 UTC) #1
Benedikt Meurer
lgtm
5 years, 6 months ago (2015-06-17 11:11:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191913002/1
5 years, 6 months ago (2015-06-17 11:12:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 11:29:57 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 11:30:13 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25e687965fdc380b722712b45716ce1a6db79e3b
Cr-Commit-Position: refs/heads/master@{#29081}

Powered by Google App Engine
This is Rietveld 408576698