Chromium Code Reviews
Help | Chromium Project | Sign in
(528)

Issue 119191: Add an extension to expose some primitives to JS for doing ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by Mike Belshe
Modified:
2 years, 9 months ago
Reviewers:
jar
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add an extension to expose some primitives to JS for doing
benchmarking from within Chrome. Because the JS resides
in the renderer and the HTTP logic resides in the browser,
this required creation of two new, control messages which
can be sent from the renderer to the browser.

These are controlled under a new commandline option
"--enable-benchmarking"

BUG=6754
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17722

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 4

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -0 lines) Lint Patch
M chrome/browser/renderer_host/resource_message_filter.h View 1 2 3 2 chunks +5 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/renderer_host/resource_message_filter.cc View 1 2 3 5 chunks +40 lines, -0 lines 0 comments 1 errors Download
M chrome/common/chrome_switches.h View 1 chunk +2 lines, -0 lines 0 comments 0 errors Download
M chrome/common/chrome_switches.cc View 1 chunk +3 lines, -0 lines 0 comments 0 errors Download
M chrome/common/render_messages_internal.h View 2 chunks +10 lines, -0 lines 0 comments 0 errors Download
M chrome/renderer/render_thread.h View 1 chunk +6 lines, -0 lines 0 comments 0 errors Download
M chrome/renderer/render_thread.cc View 3 chunks +12 lines, -0 lines 0 comments 0 errors Download
M chrome/renderer/renderer_glue.cc View 1 chunk +7 lines, -0 lines 0 comments 0 errors Download
A webkit/extensions/v8/benchmarking_extension.h View 1 chunk +23 lines, -0 lines 0 comments 1 errors Download
A webkit/extensions/v8/benchmarking_extension.cc View 1 2 3 1 chunk +62 lines, -0 lines 0 comments 3 errors Download
M webkit/glue/webkit_glue.h View 1 chunk +6 lines, -0 lines 0 comments 0 errors Download
M webkit/webkit.gyp View 1 chunk +2 lines, -0 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 4
Mike Belshe
4 years, 10 months ago #1
jar
Very cool stuff :-). I think it is safe that you allow this extension in ...
4 years, 10 months ago #2
Mike Belshe
Thanks for taking a look. On 2009/06/04 22:42:30, jar wrote: > Very cool stuff :-). ...
4 years, 10 months ago #3
jar
4 years, 10 months ago #4
One more nit listed below.

Also, please upload the changes (nits) you mentioned fixing.

With that.... LGTM.

Thanks,

Jim

http://codereview.chromium.org/119191/diff/1036/1041
File chrome/browser/renderer_host/resource_message_filter.h (right):

http://codereview.chromium.org/119191/diff/1036/1041#newcode215
Line 215: void OnSetCacheMode(bool);
style nit: All parameters must be named
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434