Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 1191903002: Add console messages when modals are suppressed due to sandboxing. (Closed)

Created:
5 years, 6 months ago by Mike West
Modified:
5 years, 6 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add console messages when modals are suppressed due to sandboxing. BUG=483624 R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197257

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M Source/core/frame/LocalDOMWindow.cpp View 5 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Mike West
WDYT?
5 years, 6 months ago (2015-06-17 10:40:25 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-17 10:56:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191903002/1
5 years, 6 months ago (2015-06-17 12:03:27 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 13:05:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197257

Powered by Google App Engine
This is Rietveld 408576698