Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1191893002: [tracing] Fix malloc accounting in memory-infra (Closed)

Created:
5 years, 6 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 6 months ago
Reviewers:
petrcermak
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tracing] Fix malloc accounting in memory-infra Currently the malloc dump provider is reporting the total virtual size as official "size" (the one plotted in the tracks) and the allocated_objects as a child. This is not fully correct, as the heap is not always necessarily used and, more importantly, creates some funky behavior when discounting the trace overehad. This change moves the outer heap size to its own property, so that the actual |uordblocks| becomes the size plotted on the track. BUG=495628, 467112 Committed: https://crrev.com/db8a28cf1603950a2dedda3329d01285a3e317cd Cr-Commit-Position: refs/heads/master@{#334812}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/trace_event/malloc_dump_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Primiano Tucci (use gerrit)
PTAL
5 years, 6 months ago (2015-06-17 10:32:25 UTC) #2
petrcermak
LGTM. We just have to make sure that we are consistent across allocators. Thanks, Petr
5 years, 6 months ago (2015-06-17 10:34:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191893002/1
5 years, 6 months ago (2015-06-17 10:35:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 11:58:18 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 11:59:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db8a28cf1603950a2dedda3329d01285a3e317cd
Cr-Commit-Position: refs/heads/master@{#334812}

Powered by Google App Engine
This is Rietveld 408576698