|
Revert of [AppRemoting] Break out AppRemoting shared module (re-land). (patchset #2 id:20001 of https://codereview.chromium.org/1179873005/)
Reason for revert:
I believe this broke the linux GN clobber build:
https://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/1309/steps/compile/logs/stdio
Traceback (most recent call last):
File "../../remoting/webapp/build-webapp.py", line 487, in <module>
sys.exit(main())
File "../../remoting/webapp/build-webapp.py", line 483, in main
return buildWebApp(**vars(args))
File "../../remoting/webapp/build-webapp.py", line 257, in buildWebApp
+ buildtype + ': ' + service_environment)
Exception: Invalid service_environment targeted for Release:
ninja: build stopped: subcommand failed.
Original issue's description:
> [AppRemoting] Break out AppRemoting shared module.
>
> This is a reland of crrev.com/1176143002 with missing files added:
> remoting/webapp/app_remoting/shared_module/manifest.json
>
> This cl breaks out the shared AppRemoting code into a shared module so
> that it does not need to be duplicated in each individual app.
>
> This version has the following limitations which will be addressed in
> follow-up cls:
> (1) The apps have a hard-coded reference to the dev shared module
> (2) The apps have a hard-coded reference to the dev orchestrator
> (3) The resources in the app stub should be replaced with empty stub
> resources rather than a copy of all the shared resources.
> (4) The shared module is only built in GN (not GYP)
>
> BUG=
>
> Committed: https://crrev.com/5b696cf0d943d03a7bd388bdca1ffc6d95d3fc9c
> Cr-Commit-Position: refs/heads/master@{#334708}
TBR=kelvinp@chromium.org,thestig@chromium.org,garykac@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Committed: https://crrev.com/6235553aac7ef07fd1ed55d55490a75bd35af4c5
Cr-Commit-Position: refs/heads/master@{#334791}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+224 lines, -490 lines) |
Patch |
 |
M |
remoting/app_remoting_webapp.gyp
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
remoting/app_remoting_webapp_build.gypi
|
View
|
|
3 chunks |
+11 lines, -21 lines |
0 comments
|
Download
|
 |
M |
remoting/app_remoting_webapp_files.gypi
|
View
|
|
4 chunks |
+6 lines, -15 lines |
0 comments
|
Download
|
 |
M |
remoting/remoting_options.gni
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
remoting/remoting_webapp_files.gypi
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
remoting/webapp/BUILD.gn
|
View
|
|
2 chunks |
+1 line, -16 lines |
0 comments
|
Download
|
 |
M |
remoting/webapp/app_remoting/html/context_menu.html
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
D |
remoting/webapp/app_remoting/html/template_background.html
|
View
|
|
1 chunk |
+0 lines, -18 lines |
0 comments
|
Download
|
 |
M |
remoting/webapp/app_remoting/html/template_feedback_consent.html
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
remoting/webapp/app_remoting/html/template_lg.html
|
View
|
|
2 chunks |
+1 line, -3 lines |
0 comments
|
Download
|
 |
M |
remoting/webapp/app_remoting/html/template_loading_window.html
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
remoting/webapp/app_remoting/js/app_remoting.js
|
View
|
|
1 chunk |
+6 lines, -40 lines |
0 comments
|
Download
|
 |
M |
remoting/webapp/app_remoting/js/app_remoting_activity.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
remoting/webapp/app_remoting/js/application_context_menu.js
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
remoting/webapp/app_remoting/js/ar_background.js
|
View
|
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
 |
A |
remoting/webapp/app_remoting/js/ar_main.js
|
View
|
|
1 chunk |
+18 lines, -0 lines |
0 comments
|
Download
|
 |
M |
remoting/webapp/app_remoting/js/feedback_consent.js
|
View
|
|
3 chunks |
+1 line, -7 lines |
0 comments
|
Download
|
 |
M |
remoting/webapp/app_remoting/manifest_common.json.jinja2
|
View
|
|
2 chunks |
+2 lines, -6 lines |
0 comments
|
Download
|
 |
D |
remoting/webapp/app_remoting/shared_module/manifest.json
|
View
|
|
1 chunk |
+0 lines, -8 lines |
0 comments
|
Download
|
 |
D |
remoting/webapp/app_remoting/vendor/arv_background.html
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
D |
remoting/webapp/app_remoting/vendor/arv_main.html
|
View
|
|
1 chunk |
+0 lines, -13 lines |
0 comments
|
Download
|
 |
D |
remoting/webapp/app_remoting/vendor/arv_main.js
|
View
|
|
1 chunk |
+0 lines, -25 lines |
0 comments
|
Download
|
 |
D |
remoting/webapp/app_remoting/vendor/arv_wcs_sandbox.html
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
A |
remoting/webapp/base/js/app_capabilities.js
|
View
|
|
1 chunk |
+18 lines, -0 lines |
0 comments
|
Download
|
 |
M |
remoting/webapp/base/js/application.js
|
View
|
|
2 chunks |
+0 lines, -10 lines |
0 comments
|
Download
|
 |
M |
remoting/webapp/base/js/message_window_helper.js
|
View
|
|
1 chunk |
+1 line, -12 lines |
0 comments
|
Download
|
 |
M |
remoting/webapp/base/js/plugin_settings.js
|
View
|
|
1 chunk |
+12 lines, -0 lines |
0 comments
|
Download
|
 |
M |
remoting/webapp/build-webapp.py
|
View
|
|
8 chunks |
+46 lines, -66 lines |
0 comments
|
Download
|
 |
M |
remoting/webapp/build_template.gni
|
View
|
|
10 chunks |
+81 lines, -181 lines |
0 comments
|
Download
|
 |
M |
remoting/webapp/crd/js/desktop_remoting.js
|
View
|
|
1 chunk |
+0 lines, -9 lines |
0 comments
|
Download
|
 |
M |
remoting/webapp/crd/js/desktop_remoting_activity.js
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
remoting/webapp/files.gni
|
View
|
|
4 chunks |
+10 lines, -20 lines |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|