Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Unified Diff: sky/examples/stocks2/lib/stock_home.dart

Issue 1191863002: Add settings page to Sky’s stocks example app (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: abarth cr feedback Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/examples/stocks2/lib/stock_app.dart ('k') | sky/examples/stocks2/lib/stock_settings.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/examples/stocks2/lib/stock_home.dart
diff --git a/sky/examples/stocks2/lib/stock_app.dart b/sky/examples/stocks2/lib/stock_home.dart
similarity index 94%
copy from sky/examples/stocks2/lib/stock_app.dart
copy to sky/examples/stocks2/lib/stock_home.dart
index 6888a4dec2138eebe9be2beb451e7cca0680dc47..7b322505cc957413eeaf20e474c40e23326c9bdd 100644
--- a/sky/examples/stocks2/lib/stock_app.dart
+++ b/sky/examples/stocks2/lib/stock_home.dart
@@ -16,6 +16,7 @@ import 'package:sky/widgets/icon_button.dart';
import 'package:sky/widgets/menu_divider.dart';
import 'package:sky/widgets/menu_item.dart';
import 'package:sky/widgets/modal_overlay.dart';
+import 'package:sky/widgets/navigator.dart';
import 'package:sky/widgets/popup_menu.dart';
import 'package:sky/widgets/radio.dart';
import 'package:sky/widgets/scaffold.dart';
@@ -28,11 +29,9 @@ import 'stock_menu.dart';
enum StockMode { optimistic, pessimistic }
-class StocksApp extends App {
+class StockHome extends Component {
- List<Stock> _stocks = [];
-
- StocksApp({ RenderView renderViewOverride }) : super(renderViewOverride: renderViewOverride) {
+ StockHome(this._navigator) {
// if (debug)
// new Timer(new Duration(seconds: 1), dumpState);
new StockDataFetcher((StockData data) {
@@ -43,6 +42,9 @@ class StocksApp extends App {
_drawerController = new DrawerController(_handleDrawerStatusChanged);
}
+ List<Stock> _stocks = [];
+ Navigator _navigator;
+
bool _isSearching = false;
String _searchQuery;
@@ -142,6 +144,7 @@ class StocksApp extends App {
new MenuItem(
key: 'Settings',
icon: 'action/settings',
+ onGestureTap: (event) => _navigator.pushNamed('/settings'),
children: [new Text('Settings')]),
new MenuItem(
key: 'Help & Feedback',
@@ -210,12 +213,3 @@ class StocksApp extends App {
return new Stack(overlays);
}
}
-
-void main() {
- print("starting stocks app!");
- App app = new StocksApp();
- WidgetAppView.appView.onFrame = () {
- // uncomment this for debugging:
- // WidgetAppView.appView.debugDumpRenderTree();
- };
-}
« no previous file with comments | « sky/examples/stocks2/lib/stock_app.dart ('k') | sky/examples/stocks2/lib/stock_settings.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698