Issue 1191863002: Add settings page to Sky’s stocks example app

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1191863002: Add settings page to Sky’s stocks example app (Closed)

Created:
5 years, 6 months ago by jackson

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add settings page to Sky’s stocks example app R=abarth@chromium.org, abarth Committed: https://chromium.googlesource.com/external/mojo/+/aca6edda7a4e39847dc0461117d163d2aaaa6529

Patch Set 2 : abarth cr feedback #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -212 lines)			Patch
M	sky/examples/stocks2/lib/stock_app.dart	View		1 chunk	+14 lines, -199 lines	0 comments	Download
A +	sky/examples/stocks2/lib/stock_home.dart	View	1	5 chunks	+7 lines, -13 lines	0 comments	Download
A	sky/examples/stocks2/lib/stock_settings.dart	View		1 chunk	+66 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

lgtm https://codereview.chromium.org/1191863002/diff/1/sky/examples/stocks2/lib/stock_home.dart File sky/examples/stocks2/lib/stock_home.dart (right): https://codereview.chromium.org/1191863002/diff/1/sky/examples/stocks2/lib/stock_home.dart#newcode29 sky/examples/stocks2/lib/stock_home.dart:29: import 'stock_settings.dart'; Is this needed?

5 years, 6 months ago (2015-06-17 00:56:59 UTC) #2

jackson

5 years, 6 months ago (2015-06-17 00:59:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
aca6edda7a4e39847dc0461117d163d2aaaa6529 (presubmit successful).

Expand Messages | Collapse Messages

Issue 1191863002: Add settings page to Sky’s stocks example app (Closed)

Description

Patch Set 1 #

Patch Set 2 : abarth cr feedback #

Messages