Source/platform/weborigin/SchemeRegistry.h - Issue 1191793003: [Service Worker Registration] removed protocolIsInHTTPFamily and replaced with SchemeRegistry check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/weborigin/SchemeRegistry.h

Issue 1191793003: [Service Worker Registration] removed protocolIsInHTTPFamily and replaced with SchemeRegistry check (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: added shouldAllowServiceWorkers in SchemeRegistry. Used instead of isSecure in ServiceWorkerContai… Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerContainer.cpp ('k') | Source/platform/weborigin/SchemeRegistry.cpp » ('j') | Source/platform/weborigin/SchemeRegistry.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/weborigin/SchemeRegistry.h

diff --git a/Source/platform/weborigin/SchemeRegistry.h b/Source/platform/weborigin/SchemeRegistry.h

index cc3e8636c8f67a528dbe25e438f6e6ac6b954b8f..9225da357e0375e8dfaf7de01191ad8c8d9671dc 100644

--- a/Source/platform/weborigin/SchemeRegistry.h

+++ b/Source/platform/weborigin/SchemeRegistry.h

@@ -87,6 +87,9 @@ public:

// "Legacy" schemes (e.g. 'ftp:', 'gopher:') which we might want to treat differently from "webby" schemes.

static bool shouldTreatURLSchemeAsLegacy(const String& scheme);

+ // Allows 'HTTP/HTTPS' and 'chrome-extension' schemes to register ServiceWorkers

+ static bool shouldAllowServiceWorkers(const String& scheme);

// Allow resources from some schemes to load on a page, regardless of its

// Content Security Policy.

// This enum should be kept in sync with public/web/WebSecurityPolicy.h.