Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 1191743002: Revert of Include unverified server-sent cert chain in reports (Closed)

Created:
5 years, 6 months ago by phoglund_chromium
Modified:
5 years, 6 months ago
Reviewers:
meacer, estark
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Include unverified server-sent cert chain in reports (patchset #2 id:20001 of https://codereview.chromium.org/1180313006/) Reason for revert: Appears this breaks CertificateErrorReportTest.SerializedReportAsProtobuf. Original issue's description: > Include unverified server-sent cert chain in reports > > As of https://codereview.chromium.org/1174073003/, net::SSLInfo contains > the unverified certificate chain as received by the client (which might > be different than the chain as built by the client during > verification). This CL adds the unverified chain to invalid certificate > reports. > > BUG=498945 > > Committed: https://crrev.com/fcac4d5822ebb8b831a2125b1800e4cc65fe6b3d > Cr-Commit-Position: refs/heads/master@{#334472} TBR=meacer@chromium.org,estark@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=498945 Committed: https://crrev.com/facc750835a9ab7b4cad70dbcc246e2353f8b531 Cr-Commit-Position: refs/heads/master@{#334564}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -47 lines) Patch
M chrome/browser/ssl/cert_logger.proto View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ssl/certificate_error_report.cc View 3 chunks +5 lines, -20 lines 0 comments Download
M chrome/browser/ssl/certificate_error_report_unittest.cc View 6 chunks +4 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
phoglund_chromium
Created Revert of Include unverified server-sent cert chain in reports
5 years, 6 months ago (2015-06-16 07:52:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191743002/1
5 years, 6 months ago (2015-06-16 07:53:17 UTC) #2
phoglund_chromium
On 2015/06/16 07:52:47, phoglund wrote: > Created Revert of Include unverified server-sent cert chain in ...
5 years, 6 months ago (2015-06-16 07:53:32 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-16 07:54:33 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 07:55:28 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/facc750835a9ab7b4cad70dbcc246e2353f8b531
Cr-Commit-Position: refs/heads/master@{#334564}

Powered by Google App Engine
This is Rietveld 408576698