Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1191653011: icu: Merge http://bugs.icu-project.org/trac/changeset/36672 (Closed)

Created:
5 years, 6 months ago by Nico
Modified:
5 years, 6 months ago
Reviewers:
scottmg
CC:
chromium-reviews, jungshik at Google
Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -12 lines) Patch
M README.chromium View 1 chunk +2 lines, -0 lines 0 comments Download
A patches/infinite-recursion.patch View 1 chunk +81 lines, -0 lines 0 comments Download
M source/i18n/filteredbrk.cpp View 1 chunk +1 line, -1 line 0 comments Download
M source/test/intltest/rbbiapts.cpp View 4 chunks +25 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Nico
5 years, 6 months ago (2015-06-18 22:22:30 UTC) #2
scottmg
the .patch doesn't look like it has \t, but the actual patch does? <shrug> lgtm
5 years, 6 months ago (2015-06-18 22:45:29 UTC) #3
Nico
On 2015/06/18 22:45:29, scottmg wrote: > the .patch doesn't look like it has \t, but ...
5 years, 6 months ago (2015-06-18 22:47:35 UTC) #4
Nico
5 years, 6 months ago (2015-06-18 22:48:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
00af1a4e512477e48ba3d5efc97adbc95462685e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698