Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1191653008: [es6] ship Rest Parameters (Closed)

Created:
5 years, 6 months ago by caitp (gmail)
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] ship Rest Parameters BUG=v8:2159 LOG=N R=arv@chromium.org, dslomov@chromium.org, rossberg@chromium.org Committed: https://crrev.com/5337508fe38f52ffd35b40bbda0b02b4b336089b Cr-Commit-Position: refs/heads/master@{#29191}

Patch Set 1 #

Patch Set 2 : rebase + make asan regress-1132.js pass #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/flag-definitions.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-1132.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
caitp (gmail)
And another flag flip
5 years, 6 months ago (2015-06-18 15:17:24 UTC) #1
arv (Not doing code reviews)
lgtm
5 years, 6 months ago (2015-06-18 15:25:47 UTC) #2
Dmitry Lomov (no reviews)
lgtm - let's land this?
5 years, 6 months ago (2015-06-22 12:39:34 UTC) #3
caitp (gmail)
On 2015/06/22 12:39:34, Dmitry S. Lomov wrote: > lgtm - let's land this? will cq ...
5 years, 6 months ago (2015-06-22 12:54:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191653008/20001
5 years, 6 months ago (2015-06-22 13:02:32 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-22 13:43:21 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 13:43:34 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5337508fe38f52ffd35b40bbda0b02b4b336089b
Cr-Commit-Position: refs/heads/master@{#29191}

Powered by Google App Engine
This is Rietveld 408576698