Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1191593005: Revert of [es6] ship Object.assign (Closed)

Created:
5 years, 6 months ago by caitp (gmail)
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [es6] ship Object.assign (patchset #2 id:20001 of https://codereview.chromium.org/1191003003/) Reason for revert: Seems to break asan somehow Original issue's description: > [es6] ship Object.assign > > BUG=v8:4007 > LOG=N > R=rossberg@chromium.org, arv@chromium.org > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/12e194860a56d47a10d89ae34761a4af6b6166bb > Cr-Commit-Position: refs/heads/master@{#29118} TBR=arv@chromium.org,dslomov@chromium.org,rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4007 Committed: https://crrev.com/95a3bc965ed80186215cea788caa5faae0898839 Cr-Commit-Position: refs/heads/master@{#29124}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/flag-definitions.h View 2 chunks +1 line, -1 line 0 comments Download
M test/webkit/fast/js/Object-getOwnPropertyNames.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
caitp (gmail)
Created Revert of [es6] ship Object.assign
5 years, 6 months ago (2015-06-18 18:55:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191593005/1
5 years, 6 months ago (2015-06-18 18:56:14 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 6 months ago (2015-06-18 18:56:16 UTC) #4
rossberg
lgtm
5 years, 6 months ago (2015-06-18 19:08:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191593005/1
5 years, 6 months ago (2015-06-18 19:15:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-18 19:15:27 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 19:15:47 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95a3bc965ed80186215cea788caa5faae0898839
Cr-Commit-Position: refs/heads/master@{#29124}

Powered by Google App Engine
This is Rietveld 408576698