[turbofan] Add CalleeSavedFPRegisters to CallDescriptor.

src/compiler/arm64/code-generator-arm64.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/code-generator.h"
 
 #include "src/arm64/macro-assembler-arm64.h"
 #include "src/compiler/code-generator-impl.h"
 #include "src/compiler/gap-resolver.h"
 #include "src/compiler/node-matchers.h"
@@ skipping 1059 matching lines @@
 }
 
 
 void CodeGenerator::AssemblePrologue() {
   CallDescriptor* descriptor = linkage()->GetIncomingDescriptor();
   int stack_slots = frame()->GetSpillSlotCount();
   if (descriptor->kind() == CallDescriptor::kCallAddress) {
     __ SetStackPointer(csp);
     __ Push(lr, fp);
     __ Mov(fp, csp);
-    // TODO(dcarney): correct callee saved registers.
-    __ PushCalleeSavedRegisters();
-    frame()->SetRegisterSaveAreaSize(20 * kPointerSize);
+
+    // Save FP registers.
+    CPURegList callee_save_fp =

[paul.l..., 2015/06/23 20:07:00]

nit: change these vars to saves_fp, and saves, to match the other arch's. This
will have small readability benefit as you (or clang-format) can move following
function up to this line using 2 lines total.

[akos.palfi.imgtec, 2015/06/23 20:33:18]

Done.

+        CPURegList(CPURegister::kFPRegister, kDRegSizeInBits,
+                   descriptor->CalleeSavedFPRegisters());
+    DCHECK(callee_save_fp.list() == CPURegList::GetCalleeSavedFP().list());
+    int saved_count = callee_save_fp.Count();
+    __ PushCPURegList(callee_save_fp);
+    // Save registers.
+    CPURegList callee_save = CPURegList(CPURegister::kRegister, kXRegSizeInBits,
+                                        descriptor->CalleeSavedRegisters());
+    // TODO(palfia): TF save list is not in sync with
+    // CPURegList::GetCalleeSaved(): x30 is missing.
+    // DCHECK(callee_save.list() == CPURegList::GetCalleeSaved().list());
+    saved_count += callee_save.Count();
+    __ PushCPURegList(callee_save);
+
+    frame()->SetRegisterSaveAreaSize(saved_count * kPointerSize);
   } else if (descriptor->IsJSFunctionCall()) {
     CompilationInfo* info = this->info();
     __ SetStackPointer(jssp);
     __ Prologue(info->IsCodePreAgingActive());
     frame()->SetRegisterSaveAreaSize(
         StandardFrameConstants::kFixedFrameSizeFromFp);
   } else if (needs_frame_) {
     __ SetStackPointer(jssp);
     __ StubPrologue();
     frame()->SetRegisterSaveAreaSize(
@@ skipping 28 matching lines @@
 
 void CodeGenerator::AssembleReturn() {
   CallDescriptor* descriptor = linkage()->GetIncomingDescriptor();
   int stack_slots = frame()->GetSpillSlotCount();
   if (descriptor->kind() == CallDescriptor::kCallAddress) {
     if (frame()->GetRegisterSaveAreaSize() > 0) {
       // Remove this frame's spill slots first.
       if (stack_slots > 0) {
         __ Add(csp, csp, AlignedStackSlots(stack_slots) * kPointerSize);
       }
+
       // Restore registers.
-      // TODO(dcarney): correct callee saved registers.
-      __ PopCalleeSavedRegisters();
+      CPURegList callee_save =
+          CPURegList(CPURegister::kRegister, kXRegSizeInBits,
+                     descriptor->CalleeSavedRegisters());
+      __ PopCPURegList(callee_save);
+
+      CPURegList callee_save_fp =

[paul.l..., 2015/06/23 20:07:00]

nit: same here.

[akos.palfi.imgtec, 2015/06/23 20:33:18]

Done.

+          CPURegList(CPURegister::kFPRegister, kDRegSizeInBits,
+                     descriptor->CalleeSavedFPRegisters());
+      __ PopCPURegList(callee_save_fp);
     }
+
     __ Mov(csp, fp);
     __ Pop(fp, lr);
     __ Ret();
   } else if (descriptor->IsJSFunctionCall() || needs_frame_) {
     __ Mov(jssp, fp);
     __ Pop(fp, lr);
     int pop_count = descriptor->IsJSFunctionCall()
                         ? static_cast<int>(descriptor->JSParameterCount())
                         : 0;
     __ Drop(pop_count);
@@ skipping 184 matching lines @@
       }
     }
   }
 }
 
 #undef __
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8