[turbofan] Add CalleeSavedFPRegisters to CallDescriptor.

src/compiler/mips64/code-generator-mips64.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/code-generator.h"
 #include "src/compiler/code-generator-impl.h"
 #include "src/compiler/gap-resolver.h"
 #include "src/compiler/node-matchers.h"
 #include "src/mips/macro-assembler-mips.h"
 #include "src/scopes.h"
@@ skipping 1117 matching lines @@
   __ Call(deopt_entry, RelocInfo::RUNTIME_ENTRY);
 }
 
 
 void CodeGenerator::AssemblePrologue() {
   CallDescriptor* descriptor = linkage()->GetIncomingDescriptor();
   int stack_slots = frame()->GetSpillSlotCount();
   if (descriptor->kind() == CallDescriptor::kCallAddress) {
     __ Push(ra, fp);
     __ mov(fp, sp);
+
+    int register_save_area_size = 0;
     const RegList saves = descriptor->CalleeSavedRegisters();
     if (saves != 0) {  // Save callee-saved registers.

[paul.l..., 2015/06/23 02:15:02]

I think we should remove this if clause, here and 3 places below. First, they
won't be zero, and removing this improves readability. Second, the macro-asm
functions do no harm with a zero reglist, but they do emit one useless
instruction. That should be fixed in separate CL for mips & mips64.

[akos.palfi.imgtec, 2015/06/23 19:48:57]

Done.

-      // TODO(plind): make callee save size const, possibly DCHECK it.
-      int register_save_area_size = 0;
-      for (int i = Register::kNumRegisters - 1; i >= 0; i--) {
-        if (!((1 << i) & saves)) continue;
-        register_save_area_size += kPointerSize;
-      }
+      __ MultiPush(saves);
+      DCHECK(kNumCalleeSaved == base::bits::CountPopulation32(saves));
+      register_save_area_size += kNumCalleeSaved * kPointerSize;
+    }
+    const RegList saves_fpu = descriptor->CalleeSavedFPRegisters();
+    if (saves_fpu != 0) {  // Save callee-saved FPU registers.
+      __ MultiPushFPU(saves_fpu);
+      DCHECK(kNumCalleeSavedFPU == base::bits::CountPopulation32(saves_fp));
+      register_save_area_size +=
+          kNumCalleeSavedFPU * kDoubleSize * kPointerSize;
+    }
+    if (register_save_area_size > 0) {
       frame()->SetRegisterSaveAreaSize(register_save_area_size);
-      __ MultiPush(saves);
     }
   } else if (descriptor->IsJSFunctionCall()) {
     CompilationInfo* info = this->info();
     __ Prologue(info->IsCodePreAgingActive());
     frame()->SetRegisterSaveAreaSize(
         StandardFrameConstants::kFixedFrameSizeFromFp);
   } else if (needs_frame_) {
     __ StubPrologue();
     frame()->SetRegisterSaveAreaSize(
         StandardFrameConstants::kFixedFrameSizeFromFp);
@@ skipping 23 matching lines @@
 
 void CodeGenerator::AssembleReturn() {
   CallDescriptor* descriptor = linkage()->GetIncomingDescriptor();
   int stack_slots = frame()->GetSpillSlotCount();
   if (descriptor->kind() == CallDescriptor::kCallAddress) {
     if (frame()->GetRegisterSaveAreaSize() > 0) {
       // Remove this frame's spill slots first.
       if (stack_slots > 0) {
         __ Daddu(sp, sp, Operand(stack_slots * kPointerSize));
       }
-      // Restore registers.
+      // Restore FPU registers.
+      const RegList saves_fpu = descriptor->CalleeSavedFPRegisters();
+      if (saves_fpu != 0) {
+        __ MultiPopFPU(saves_fpu);
+      }
+      // Restore GP registers.
       const RegList saves = descriptor->CalleeSavedRegisters();
       if (saves != 0) {
         __ MultiPop(saves);
       }
     }
     __ mov(sp, fp);
     __ Pop(ra, fp);
     __ Ret();
   } else if (descriptor->IsJSFunctionCall() || needs_frame_) {
     __ mov(sp, fp);
@@ skipping 213 matching lines @@
     }
   }
   MarkLazyDeoptSite();
 }
 
 #undef __
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8