Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1191513002: Don't clear in SkSurface::NewWrappedRenderTarget (Closed)

Created:
5 years, 6 months ago by bsalomon
Modified:
5 years, 6 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Don't clear in SkSurface::NewWrappedRenderTarget Committed: https://skia.googlesource.com/skia/+/7a61793d9603f07a9039b5abf814eb25842e211b

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 1

Patch Set 3 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -24 lines) Patch
M src/image/SkSurface_Gpu.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M tests/SurfaceTest.cpp View 1 2 2 chunks +81 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
bsalomon
5 years, 6 months ago (2015-06-15 15:39:16 UTC) #2
reed1
nit in test file lgtm https://codereview.chromium.org/1191513002/diff/20001/tests/SurfaceTest.cpp File tests/SurfaceTest.cpp (right): https://codereview.chromium.org/1191513002/diff/20001/tests/SurfaceTest.cpp#newcode22 tests/SurfaceTest.cpp:22: #include "gl/GrGLUtil.h"#else LF before ...
5 years, 6 months ago (2015-06-15 16:09:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191513002/40001
5 years, 6 months ago (2015-06-16 15:02:02 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 15:07:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/7a61793d9603f07a9039b5abf814eb25842e211b

Powered by Google App Engine
This is Rietveld 408576698