Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1191493004: Use default flag style for multi-value flags if no switches have been passed. (Closed)

Created:
5 years, 6 months ago by flackr
Modified:
5 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use default flag style for multi-value flags if no switches have been passed. BUG=None TEST=Multi value experiments on chrome://flags have same style as single value experiments when no overriding flags have been passed. Committed: https://crrev.com/ba836b2379ab2661b8cd678d34f16716225bd418 Cr-Commit-Position: refs/heads/master@{#335138}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M chrome/browser/about_flags.cc View 2 chunks +23 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
flackr
This patch makes the style of multi value experiments (on chrome://flags) the same as single ...
5 years, 6 months ago (2015-06-15 17:05:52 UTC) #2
flackr
Friendly ping to rise back to the top of your inbox :-)
5 years, 6 months ago (2015-06-18 20:56:01 UTC) #3
Nico
lgtm
5 years, 6 months ago (2015-06-18 20:58:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191493004/1
5 years, 6 months ago (2015-06-18 21:02:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-18 21:57:20 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 21:58:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba836b2379ab2661b8cd678d34f16716225bd418
Cr-Commit-Position: refs/heads/master@{#335138}

Powered by Google App Engine
This is Rietveld 408576698