Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1191483002: Revert of Oilpan: adjust GC policy under memory pressure. (Closed)

Created:
5 years, 6 months ago by sof
Modified:
5 years, 6 months ago
Reviewers:
haraken
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Oilpan: adjust GC policy under memory pressure. (patchset #4 id:60001 of https://codereview.chromium.org/1174123002/) Reason for revert: Plausible candidate for regressing v8 GC totals on v8.top_25_smooth somewhat, https://code.google.com/p/chromium/issues/detail?id=499822 Original issue's description: > Oilpan: adjust GC policy under memory pressure. > > When notified of a v8 major GC, check if we're under memory pressure and > overdue an Oilpan GC & urgently. If so, force a conservative GC right > away. > > This addresses dom-modify.html OOM troubles on win32, in particular. It > runs into the allocation pattern where the Oilpan allocator is able to > handle a tight loop just allocating Text nodes by bump allocating each > such node. Each Text node has a large external string allocation however, > which leads to a steep ramp-upin overall allocation amounts to the point > where it might OOM as no Oilpan GCs will run. v8 will however notice the > increasing memory pressure and schedule major GCs of its own. > > Oilpan is notified after each v8 major GC, so use that opportunity to > check for memory pressure & force an Oilpan GC right away. > > R=haraken > BUG=420515 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196953 TBR=haraken@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197114

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -88 lines) Patch
M Source/bindings/core/v8/V8GCController.cpp View 2 chunks +41 lines, -7 lines 0 comments Download
M Source/platform/heap/ThreadState.h View 2 chunks +2 lines, -8 lines 0 comments Download
M Source/platform/heap/ThreadState.cpp View 5 chunks +19 lines, -73 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sof
Created Revert of Oilpan: adjust GC policy under memory pressure.
5 years, 6 months ago (2015-06-15 14:29:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191483002/1
5 years, 6 months ago (2015-06-15 14:30:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=197114
5 years, 6 months ago (2015-06-15 14:31:02 UTC) #3
haraken
5 years, 6 months ago (2015-06-15 15:28:24 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698