Implement "open link as user" context menu entry

chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc

Index: chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc b/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
index 823dbafd91146a952989ae94ee5928c5f2e6039d..a36714ddc09ccffd44e8a85273d1dcf2391841cf 100644
--- a/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
+++ b/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
@@ -10,9 +10,12 @@
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string16.h"
+#include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
+#include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
+#include "chrome/browser/profiles/profile_window.h"
 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
 #include "chrome/browser/renderer_context_menu/render_view_context_menu_browsertest_util.h"
 #include "chrome/browser/renderer_context_menu/render_view_context_menu_test_util.h"
@@ -42,6 +45,11 @@
 #include "third_party/WebKit/public/web/WebContextMenuData.h"
 #include "third_party/WebKit/public/web/WebInputEvent.h"
 
+#if defined(OS_CHROMEOS)
+#include "chrome/browser/chromeos/profiles/profile_helper.h"
+#include "components/user_manager/user_manager.h"
+#endif
+
 using content::WebContents;
 
 namespace {
@@ -80,6 +88,23 @@ class ContextMenuBrowserTest : public InProcessBrowserTest {
     return CreateContextMenu(unfiltered_url, url,
                              blink::WebContextMenuData::MediaTypeNone);
   }
+
+  Profile* CreateSecondaryProfile(int profile_num) {
+    ProfileManager* profile_manager = g_browser_process->profile_manager();
+    base::FilePath profile_path = profile_manager->user_data_dir();
+#if defined(OS_CHROMEOS)
+    std::string profile_name = base::StringPrintf("NewProfile%d", profile_num);
+    user_manager::UserManager::Get()->UserLoggedIn(
+        base::StringPrintf("user%d@test.com", profile_num), profile_name,
+        false);
+    profile_path = profile_path.Append(
+        chromeos::ProfileHelper::GetUserProfileDir(profile_name).BaseName());
+#else
+    profile_path = profile_path.AppendASCII(
+        base::StringPrintf("New Profile %d", profile_num));
+#endif
+    return profile_manager->GetProfile(profile_path);
+  }
 };
 
 IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest,
@@ -90,6 +115,9 @@ IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest,
   ASSERT_TRUE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_OPENLINKNEWTAB));
   ASSERT_TRUE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_OPENLINKNEWWINDOW));
   ASSERT_TRUE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_COPYLINKLOCATION));
+  ASSERT_FALSE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_OPENLINKINPROFILE));
+  ASSERT_FALSE(menu->IsItemInRangePresent(IDC_OPEN_LINK_IN_PROFILE_FIRST,
+                                          IDC_OPEN_LINK_IN_PROFILE_LAST));
 }
 
 IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest,
@@ -100,6 +128,9 @@ IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest,
   ASSERT_FALSE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_OPENLINKNEWTAB));
   ASSERT_FALSE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_OPENLINKNEWWINDOW));
   ASSERT_TRUE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_COPYLINKLOCATION));
+  ASSERT_FALSE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_OPENLINKINPROFILE));
+  ASSERT_FALSE(menu->IsItemInRangePresent(IDC_OPEN_LINK_IN_PROFILE_FIRST,
+                                          IDC_OPEN_LINK_IN_PROFILE_LAST));
 }
 
 IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest,
@@ -351,6 +382,87 @@ IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest, OpenImageInNewTab) {
   ASSERT_TRUE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_OPENIMAGENEWTAB));
 }
 
+IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest, OpenLinkInProfileEntryPresent) {
+  Profile* profile1 = CreateSecondaryProfile(1);
+  Profile* profile2 = CreateSecondaryProfile(2);
+  {
+    scoped_ptr<TestRenderViewContextMenu> menu(CreateContextMenuMediaTypeNone(
+        GURL("http://www.google.com/"), GURL("http://www.google.com/")));
+
+    ASSERT_TRUE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_OPENLINKNEWTAB));
+    ASSERT_TRUE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_OPENLINKNEWWINDOW));
+    ASSERT_TRUE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_COPYLINKLOCATION));
+    // We only show the menu if the profiles actually have an active browser.
+    ASSERT_FALSE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_OPENLINKINPROFILE));
+    ASSERT_FALSE(menu->IsItemInRangePresent(IDC_OPEN_LINK_IN_PROFILE_FIRST,
+                                            IDC_OPEN_LINK_IN_PROFILE_LAST));
+  }
+
+  profiles::FindOrCreateNewWindowForProfile(
+      profile1, chrome::startup::IS_NOT_PROCESS_STARTUP,
+      chrome::startup::IS_NOT_FIRST_RUN, chrome::GetActiveDesktop(), false);
+  {
+    scoped_ptr<TestRenderViewContextMenu> menu(CreateContextMenuMediaTypeNone(
+        GURL("http://www.google.com/"), GURL("http://www.google.com/")));
+
+    ASSERT_TRUE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_OPENLINKNEWTAB));
+    ASSERT_TRUE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_OPENLINKNEWWINDOW));
+    ASSERT_TRUE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_COPYLINKLOCATION));
+    // With two profiles, we don't show a submenu.

[Peter Kasting, 2015/06/15 23:45:15]

This comment is the same as the one below, but the code in the two places is
different.

[jochen (gone - plz use gerrit), 2015/06/16 08:00:14]

done

[Peter Kasting, 2015/06/16 08:20:24]

I'm still confused.  Now the two comments both mention "three profiles" but
describe doing different things.

Honestly, it looks as if the tests are backwards.  Shouldn't the test here, when
there are only main and "profile 1" windows open, ASSERT_TRUE on the
OPENLINKINPROFILE item and false on the range; then the test below, once we've
opened a "profile 2" window, be the reverse?

[jochen (gone - plz use gerrit), 2015/06/16 09:01:50]

I shouldn't try to write comments in the early morning...

Tried to clarify what happens.

The test creates three profiles (default + two additional ones) and then
verifies that no open link in profile is created.

Then it opens one window in the second profile, now the inline item should be
displayed.

Then it also opens one window in the third profile, no a submenu should be
displayed.

+    ASSERT_FALSE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_OPENLINKINPROFILE));
+    ASSERT_TRUE(menu->IsItemInRangePresent(IDC_OPEN_LINK_IN_PROFILE_FIRST,
+                                           IDC_OPEN_LINK_IN_PROFILE_LAST));
+  }
+
+  profiles::FindOrCreateNewWindowForProfile(
+      profile2, chrome::startup::IS_NOT_PROCESS_STARTUP,
+      chrome::startup::IS_NOT_FIRST_RUN, chrome::GetActiveDesktop(), false);
+  {
+    scoped_ptr<TestRenderViewContextMenu> menu(CreateContextMenuMediaTypeNone(
+        GURL("http://www.google.com/"), GURL("http://www.google.com/")));
+
+    ASSERT_TRUE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_OPENLINKNEWTAB));
+    ASSERT_TRUE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_OPENLINKNEWWINDOW));
+    ASSERT_TRUE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_COPYLINKLOCATION));
+    // With three or more profiles, we don't show a submenu.
+    ASSERT_TRUE(menu->IsItemPresent(IDC_CONTENT_CONTEXT_OPENLINKINPROFILE));
+    ASSERT_FALSE(menu->IsItemInRangePresent(IDC_OPEN_LINK_IN_PROFILE_FIRST,
+                                            IDC_OPEN_LINK_IN_PROFILE_LAST));
+  }
+}
+
+IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest, OpenLinkInProfile) {
+  Profile* other_profile = CreateSecondaryProfile(1);
+  profiles::FindOrCreateNewWindowForProfile(
+      other_profile, chrome::startup::IS_NOT_PROCESS_STARTUP,
+      chrome::startup::IS_NOT_FIRST_RUN, chrome::GetActiveDesktop(), false);
+
+  ui_test_utils::WindowedTabAddedNotificationObserver tab_observer(
+      content::NotificationService::AllSources());
+
+  ASSERT_TRUE(test_server()->Start());
+  GURL url(test_server()->GetURL(std::string()));
+
+  scoped_ptr<TestRenderViewContextMenu> menu(
+      CreateContextMenuMediaTypeNone(url, url));
+
+  menu->ExecuteCommand(
+      IDC_OPEN_LINK_IN_PROFILE_FIRST +
+          g_browser_process->profile_manager()
+              ->GetProfileInfoCache()
+              .GetIndexOfProfileWithPath(other_profile->GetPath()),
+      0);
+
+  tab_observer.Wait();
+  content::WebContents* tab = tab_observer.GetTab();
+  content::WaitForLoadStop(tab);
+
+  // Verify that it's the correct tab and profile.
+  ASSERT_EQ(url, tab->GetURL());
+  ASSERT_EQ(other_profile,
+            Profile::FromBrowserContext(tab->GetBrowserContext()));
+}
+
 class ThumbnailResponseWatcher : public content::NotificationObserver {
  public:
   enum QuitReason {