Implement "open link as user" context menu entry

chrome/browser/renderer_context_menu/render_view_context_menu.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
 
 #include <algorithm>
 #include <set>
 #include <utility>
 
@@ skipping 19 matching lines @@
 #include "chrome/browser/download/download_service_factory.h"
 #include "chrome/browser/download/download_stats.h"
 #include "chrome/browser/extensions/devtools_util.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h"
 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_factory.h"
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 #include "chrome/browser/plugins/chrome_plugin_service_filter.h"
 #include "chrome/browser/prefs/incognito_mode_prefs.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/profiles/profile_avatar_icon_util.h"
+#include "chrome/browser/profiles/profile_info_cache.h"
 #include "chrome/browser/profiles/profile_io_data.h"
+#include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/profiles/profile_window.h"
 #include "chrome/browser/renderer_context_menu/context_menu_content_type_factory.h"
 #include "chrome/browser/renderer_context_menu/spellchecker_submenu_observer.h"
 #include "chrome/browser/renderer_context_menu/spelling_menu_observer.h"
 #include "chrome/browser/search/search.h"
 #include "chrome/browser/search_engines/template_url_service_factory.h"
 #include "chrome/browser/spellchecker/spellcheck_host_metrics.h"
 #include "chrome/browser/spellchecker/spellcheck_service.h"
 #include "chrome/browser/tab_contents/retargeting_details.h"
 #include "chrome/browser/translate/chrome_translate_client.h"
 #include "chrome/browser/translate/translate_service.h"
@@ skipping 167 matching lines @@
     {58, IDC_SPELLCHECK_SUGGESTION_0},
     {59, IDC_SPELLCHECK_ADD_TO_DICTIONARY},
     {60, IDC_SPELLPANEL_TOGGLE},
     {61, IDC_CONTENT_CONTEXT_OPEN_ORIGINAL_IMAGE_NEW_TAB},
     {62, IDC_WRITING_DIRECTION_MENU},
     {63, IDC_WRITING_DIRECTION_DEFAULT},
     {64, IDC_WRITING_DIRECTION_LTR},
     {65, IDC_WRITING_DIRECTION_RTL},
     {66, IDC_CONTENT_CONTEXT_SHOW_ORIGINAL_IMAGE},
     {67, IDC_CONTENT_CONTEXT_FORCESAVEPASSWORD},
+    {68, IDC_OPEN_LINK_IN_PROFILE_FIRST},
     // Add new items here and use |enum_id| from the next line.
     // Also, add new items to RenderViewContextMenuItem enum in histograms.xml.
-    {68, 0},  // Must be the last. Increment |enum_id| when new IDC was added.
+    {69, 0},  // Must be the last. Increment |enum_id| when new IDC was added.
 };
 
 // Collapses large ranges of ids before looking for UMA enum.
 int CollapseCommandsForUMA(int id) {
   DCHECK(!RenderViewContextMenu::IsContentCustomCommandId(id));
   DCHECK(!ContextMenuMatcher::IsExtensionsCustomCommandId(id));
 
   if (id >= IDC_CONTENT_CONTEXT_PROTOCOL_HANDLER_FIRST &&
       id <= IDC_CONTENT_CONTEXT_PROTOCOL_HANDLER_LAST) {
     return IDC_CONTENT_CONTEXT_PROTOCOL_HANDLER_FIRST;
   }
 
   if (id >= IDC_SPELLCHECK_LANGUAGES_FIRST &&
       id <= IDC_SPELLCHECK_LANGUAGES_LAST) {
     return IDC_SPELLCHECK_LANGUAGES_FIRST;
   }
 
   if (id >= IDC_SPELLCHECK_SUGGESTION_0 &&
       id <= IDC_SPELLCHECK_SUGGESTION_LAST) {
     return IDC_SPELLCHECK_SUGGESTION_0;
   }
 
+  if (id >= IDC_OPEN_LINK_IN_PROFILE_FIRST &&
+      id <= IDC_OPEN_LINK_IN_PROFILE_LAST) {
+    return IDC_OPEN_LINK_IN_PROFILE_FIRST;
+  }
+
   return id;
 }
 
 // Returns UMA enum value for command specified by |id| or -1 if not found.
 int FindUMAEnumValueForCommand(int id) {
   if (RenderViewContextMenu::IsContentCustomCommandId(id))
     return 0;
 
   if (ContextMenuMatcher::IsExtensionsCustomCommandId(id))
     return 1;
@@ skipping 101 matching lines @@
 }
 
 RenderViewContextMenu::RenderViewContextMenu(
     content::RenderFrameHost* render_frame_host,
     const content::ContextMenuParams& params)
     : RenderViewContextMenuBase(render_frame_host, params),
       extension_items_(browser_context_,
                        this,
                        &menu_model_,
                        base::Bind(MenuItemMatchesParams, params_)),
+      profile_link_submenu_model_(this),
       protocol_handler_submenu_model_(this),
       protocol_handler_registry_(
           ProtocolHandlerRegistryFactory::GetForBrowserContext(GetProfile())),
       embedder_web_contents_(GetWebContentsToUse(source_web_contents_)) {
   if (!g_custom_id_ranges_initialized) {
     g_custom_id_ranges_initialized = true;
     SetContentCustomCommandIdRange(IDC_CONTENT_CONTEXT_CUSTOM_FIRST,
                                    IDC_CONTENT_CONTEXT_CUSTOM_LAST);
   }
   set_content_type(ContextMenuContentTypeFactory::Create(
@@ skipping 341 matching lines @@
 void RenderViewContextMenu::AppendLinkItems() {
   if (!params_.link_url.is_empty()) {
     menu_model_.AddItemWithStringId(IDC_CONTENT_CONTEXT_OPENLINKNEWTAB,
                                     IDS_CONTENT_CONTEXT_OPENLINKNEWTAB);
     menu_model_.AddItemWithStringId(IDC_CONTENT_CONTEXT_OPENLINKNEWWINDOW,
                                     IDS_CONTENT_CONTEXT_OPENLINKNEWWINDOW);
     if (params_.link_url.is_valid()) {
       AppendProtocolHandlerSubMenu();
     }
 
+    // g_browser_process->profile_manager() is NULL during unit tests.

[Peter Kasting, 2015/06/15 23:45:15]

Is null, or may be null?  (i.e. Is it ever non-null?)

[jochen (gone - plz use gerrit), 2015/06/16 08:00:14]

it's always null during the context menu unit tests.

[Peter Kasting, 2015/06/16 08:20:24]

OK.  (Prefer "null" to "NULL", though.)

[jochen (gone - plz use gerrit), 2015/06/16 09:01:50]

done

+    if (g_browser_process->profile_manager() &&
+        GetProfile()->GetProfileType() == Profile::REGULAR_PROFILE) {
+      ProfileManager* profile_manager = g_browser_process->profile_manager();
+      ProfileInfoCache& profile_info_cache =

[Peter Kasting, 2015/06/15 23:45:15]

I believe that if you mark ProfileInfoCache::GetAvatarIconOfProfileAtIndex() as
a const function, this can become a const ref.  (I think that function is, in
fact, const, so this should be possible.)

[jochen (gone - plz use gerrit), 2015/06/16 08:00:13]

done

+          profile_manager->GetProfileInfoCache();
+
+      std::vector<Profile*> target_profiles;

[Peter Kasting, 2015/06/15 23:45:15]

Nit: Maybe above this block say something like "Find all regular profiles other
than the current one which have at least one open window."

[jochen (gone - plz use gerrit), 2015/06/16 08:00:13]

done

+      std::vector<Profile*> all_profiles = profile_manager->GetLoadedProfiles();
+      chrome::HostDesktopType desktop_type =
+          chrome::FindBrowserWithWebContents(source_web_contents_)

[Peter Kasting, 2015/06/15 23:45:15]

See null-check question I have about this in ExecuteCommand() below.

[jochen (gone - plz use gerrit), 2015/06/16 08:00:13]

done

+              ->host_desktop_type();
+      for (std::vector<Profile*>::iterator it = all_profiles.begin();
+           it != all_profiles.end(); ++it) {

[Peter Kasting, 2015/06/15 23:45:15]

Nit: Use range-based for

[jochen (gone - plz use gerrit), 2015/06/16 08:00:14]

done

+        if ((*it)->GetProfileType() != Profile::REGULAR_PROFILE)

[Peter Kasting, 2015/06/15 23:45:15]

Nit: Shorter:

        if ((profile->GetProfileType() == Profile::REGULAR_PROFILE) &&
            (profile != GetProfile() &&
            chrome::FindLastActiveWithProfile(profile, desktop_type))
          target_profiles.push_back(profile);

[jochen (gone - plz use gerrit), 2015/06/16 08:00:13]

done

+          continue;
+        if (*it == GetProfile())
+          continue;
+
+        // A loaded profile doesn't necessary have an open window associated
+        // with it.
+        if (!chrome::FindLastActiveWithProfile(*it, desktop_type))
+          continue;
+        target_profiles.push_back(*it);
+      }
+
+      if (target_profiles.size() == 1) {
+        Profile* profile = target_profiles[0];
+        size_t profile_index =
+            profile_info_cache.GetIndexOfProfileWithPath(profile->GetPath());
+        menu_model_.AddItem(
+            IDC_OPEN_LINK_IN_PROFILE_FIRST + profile_index,
+            l10n_util::GetStringFUTF16(
+                IDS_CONTENT_CONTEXT_OPENLINKINPROFILE,
+                profile_info_cache.GetNameOfProfileAtIndex(profile_index)));
+      } else if (target_profiles.size() > 1) {

[Peter Kasting, 2015/06/15 23:45:15]

Can this conditional ever fail?

[jochen (gone - plz use gerrit), 2015/06/16 08:00:13]

there could be no target_profile (since target_profile does not include the
current profile)

[Peter Kasting, 2015/06/16 08:20:24]

OK; how about "} else if (!target_profiles.empty()) {" then.

[jochen (gone - plz use gerrit), 2015/06/16 09:01:50]

done

+        for (std::vector<Profile*>::iterator it = target_profiles.begin();
+             it != target_profiles.end(); ++it) {

[Peter Kasting, 2015/06/15 23:45:15]

Nit: Use range-based for

[jochen (gone - plz use gerrit), 2015/06/16 08:00:14]

done

+          Profile* profile = *it;
+          size_t profile_index =
+              profile_info_cache.GetIndexOfProfileWithPath(profile->GetPath());
+          profile_link_submenu_model_.AddItem(
+              IDC_OPEN_LINK_IN_PROFILE_FIRST + profile_index,
+              profile_info_cache.GetNameOfProfileAtIndex(profile_index));
+          gfx::Image icon =
+              profile_info_cache.GetAvatarIconOfProfileAtIndex(profile_index);
+          int width = icon.Width();
+          int height = icon.Height();
+          gfx::CalculateFaviconTargetSize(&width, &height);
+          profile_link_submenu_model_.SetIcon(
+              profile_link_submenu_model_.GetItemCount() - 1,
+              profiles::GetSizedAvatarIcon(icon, true, width, height));
+        }
+        menu_model_.AddSubMenuWithStringId(
+            IDC_CONTENT_CONTEXT_OPENLINKINPROFILE,
+            IDS_CONTENT_CONTEXT_OPENLINKINPROFILES,
+            &profile_link_submenu_model_);
+      }
+    }
+
     menu_model_.AddItemWithStringId(IDC_CONTENT_CONTEXT_OPENLINKOFFTHERECORD,
                                     IDS_CONTENT_CONTEXT_OPENLINKOFFTHERECORD);
     menu_model_.AddItemWithStringId(IDC_CONTENT_CONTEXT_SAVELINKAS,
                                     IDS_CONTENT_CONTEXT_SAVELINKAS);
   }
 
   menu_model_.AddItemWithStringId(
       IDC_CONTENT_CONTEXT_COPYLINKLOCATION,
       params_.link_url.SchemeIs(url::kMailToScheme) ?
           IDS_CONTENT_CONTEXT_COPYEMAILADDRESS :
@@ skipping 342 matching lines @@
 
   // Extension items.
   if (ContextMenuMatcher::IsExtensionsCustomCommandId(id))
     return extension_items_.IsCommandIdEnabled(id);
 
   if (id >= IDC_CONTENT_CONTEXT_PROTOCOL_HANDLER_FIRST &&
       id <= IDC_CONTENT_CONTEXT_PROTOCOL_HANDLER_LAST) {
     return true;
   }
 
+  if (id >= IDC_OPEN_LINK_IN_PROFILE_FIRST &&
+      id <= IDC_OPEN_LINK_IN_PROFILE_LAST) {
+    return params_.link_url.is_valid();
+  }
+
   IncognitoModePrefs::Availability incognito_avail =
       IncognitoModePrefs::GetAvailability(prefs);
   switch (id) {
     case IDC_BACK:
       return embedder_web_contents_->GetController().CanGoBack();
 
     case IDC_FORWARD:
       return embedder_web_contents_->GetController().CanGoForward();
 
     case IDC_RELOAD: {
@@ skipping 46 matching lines @@
              // There are some application locales which can't be used as a
              // target language for translation.
              translate::TranslateDownloadManager::IsSupportedLanguage(
                  target_lang) &&
              // Disable on the Instant Extended NTP.
              !chrome::IsInstantNTP(embedder_web_contents_);
     }
 
     case IDC_CONTENT_CONTEXT_OPENLINKNEWTAB:
     case IDC_CONTENT_CONTEXT_OPENLINKNEWWINDOW:
+    case IDC_CONTENT_CONTEXT_OPENLINKINPROFILE:
       return params_.link_url.is_valid();
 
     case IDC_CONTENT_CONTEXT_COPYLINKLOCATION:
       return params_.unfiltered_link_url.is_valid();
 
     case IDC_CONTENT_CONTEXT_SAVELINKAS: {
       PrefService* local_state = g_browser_process->local_state();
       DCHECK(local_state);
       // Test if file-selection dialogs are forbidden by policy.
       if (!local_state->GetBoolean(prefs::kAllowFileSelectionDialogs))
@@ skipping 237 matching lines @@
     int handlerIndex = id - IDC_CONTENT_CONTEXT_PROTOCOL_HANDLER_FIRST;
     WindowOpenDisposition disposition =
         ForceNewTabDispositionFromEventFlags(event_flags);
     OpenURL(handlers[handlerIndex].TranslateUrl(params_.link_url),
             GetDocumentURL(params_),
             disposition,
             ui::PAGE_TRANSITION_LINK);
     return;
   }
 
+  if (id >= IDC_OPEN_LINK_IN_PROFILE_FIRST &&
+      id <= IDC_OPEN_LINK_IN_PROFILE_LAST) {
+    ProfileManager* profile_manager = g_browser_process->profile_manager();
+    ProfileInfoCache& profile_info_cache =
+        profile_manager->GetProfileInfoCache();
+
+    base::FilePath profile_path = profile_info_cache.GetPathOfProfileAtIndex(
+        id - IDC_OPEN_LINK_IN_PROFILE_FIRST);
+    Profile* profile = profile_manager->GetProfileByPath(profile_path);
+    DCHECK(profile);
+
+    chrome::HostDesktopType desktop_type =
+        chrome::FindBrowserWithWebContents(source_web_contents_)

[Peter Kasting, 2015/06/15 23:45:15]

The code below for IDC_CONTENT_CONTEXT_OPENLINKNEWTAB null-checks the result of
this call.  Does this code need to do that?  It seems like these need to be the
same, though I'm not precisely sure how this could return null in either case?

[jochen (gone - plz use gerrit), 2015/06/16 08:00:13]

fair point. I'm getting the desktop_top from the native view then

+            ->host_desktop_type();
+
+    Browser* browser = chrome::FindLastActiveWithProfile(profile, desktop_type);
+    chrome::NavigateParams nav_params(browser, params_.link_url,
+                                      ui::PAGE_TRANSITION_LINK);
+    nav_params.disposition = NEW_FOREGROUND_TAB;
+    nav_params.referrer = content::Referrer::SanitizeForRequest(
+        params_.link_url,
+        content::Referrer(GetDocumentURL(params_).GetAsReferrer(),
+                          params_.referrer_policy));
+    nav_params.window_action = chrome::NavigateParams::SHOW_WINDOW;
+    if (!browser) {
+      profiles::FindOrCreateNewWindowForProfile(
+          profile, chrome::startup::IS_NOT_PROCESS_STARTUP,
+          chrome::startup::IS_NOT_FIRST_RUN, desktop_type,
+          false /* always_create */);
+      nav_params.browser =
+          chrome::FindLastActiveWithProfile(profile, desktop_type);
+      DCHECK(nav_params.browser);
+      nav_params.disposition = CURRENT_TAB;
+    }
+    chrome::Navigate(&nav_params);
+    return;
+  }
+
   switch (id) {
     case IDC_CONTENT_CONTEXT_OPENLINKNEWTAB: {
       Browser* browser =
           chrome::FindBrowserWithWebContents(source_web_contents_);
       OpenURL(params_.link_url,
               GetDocumentURL(params_),
               !browser || browser->is_app() ?
                   NEW_FOREGROUND_TAB : NEW_BACKGROUND_TAB,
               ui::PAGE_TRANSITION_LINK);
       break;
@@ skipping 480 matching lines @@
   source_web_contents_->GetRenderViewHost()->
       ExecuteMediaPlayerActionAtLocation(location, action);
 }
 
 void RenderViewContextMenu::PluginActionAt(
     const gfx::Point& location,
     const WebPluginAction& action) {
   source_web_contents_->GetRenderViewHost()->
       ExecutePluginActionAtLocation(location, action);
 }