Issue 1191443009: Introduce a LeafRenderObjectWrapper abstract class so that RenderObjectWrappers that are leaves don…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1191443009: Introduce a LeafRenderObjectWrapper abstract class so that RenderObjectWrappers that are leaves don… (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Introduce a LeafRenderObjectWrapper abstract class so that RenderObjectWrappers that are leaves don't have to all redundantly assert that they're not misused. Also, make images use their URL as their src. Other misc code cleanup. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/edc9d9467a0f0880d2221d86f8659f790d1a5768

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -24 lines)			Patch
	M	sky/sdk/lib/widgets/basic.dart	View		5 chunks	+10 lines, -24 lines	0 comments	Download
	M	sky/sdk/lib/widgets/widget.dart	View		1 chunk	+14 lines, -0 lines	0 comments	Download

Total messages: 3 (1 generated)

Hixie

5 years, 6 months ago (2015-06-18 00:08:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
edc9d9467a0f0880d2221d86f8659f790d1a5768 (presubmit successful).