VideoCaptureParams: add flag for hinting capture using GpuMemoryBuffers & flag for it

VideoCaptureParams: add flag for hinting capture using GpuMemoryBuffers & flag for it

This CL adds a command line flag and storage for
it in VideoCaptureParams, so we can hint the Video
Capture Device to use native GpuMemoryBuffers.
Ths is an experimental CL to be used while other
moving parts of the capture using GMBs are landed
and performance numbers/finch experiments are
collected.

For consistency with Style Guide, VideoCaptureFormat
and VideoCaptureParams are changed from class to
struct.

This flag is only used in Linux.

BUG=440843
Committed: https://crrev.com/354e3e2d4a380bf463d683d853c27227729d15f0
Cr-Commit-Position: refs/heads/master@{#334674}

[mcasas, 2015-06-15 16:15:02]

Patchset #1 (id:1) has been deleted

[mcasas, 2015-06-15 16:37:38]

Patchset #1 (id:20001) has been deleted

[mcasas, 2015-06-15 16:45:18]

Patchset #1 (id:40001) has been deleted

[mcasas, 2015-06-15 18:03:17]

Patchset #1 (id:60001) has been deleted

[mcasas, 2015-06-15 18:42:37]

Patchset #1 (id:50006) has been deleted

[mcasas, 2015-06-15 18:44:39]

mcasas@chromium.org changed reviewers:
+ tommi@chromium.org

[mcasas, 2015-06-15 18:44:39]

tommi@ PTAL/Owners RS

[tommi (sloooow) - chröme, 2015-06-15 19:08:58]

https://codereview.chromium.org/1191443003/diff/90001/media/base/video_captur...
File media/base/video_capture_types.h (right):

https://codereview.chromium.org/1191443003/diff/90001/media/base/video_captur...
media/base/video_capture_types.h:106: bool operator==(const VideoCaptureParams&
other) const {
update this operator too?

https://codereview.chromium.org/1191443003/diff/90001/media/base/video_captur...
media/base/video_capture_types.h:119: bool use_native_gpu_memory_buffers;
the member variables in this class and above, don't follow the style guide. 
Should they be a struct?

[mcasas, 2015-06-15 20:29:20]

Patchset #2 (id:110001) has been deleted

[mcasas, 2015-06-15 23:22:22]

Patchset #2 (id:110001) has been deleted

[mcasas, 2015-06-15 23:22:31]

Patchset #2 (id:130001) has been deleted

[mcasas, 2015-06-15 23:33:41]

Patchset #2 (id:150001) has been deleted

[mcasas, 2015-06-15 23:43:00]

Patchset #2 (id:170001) has been deleted

[mcasas, 2015-06-16 00:09:44]

Patchset #2 (id:80005) has been deleted

[mcasas, 2015-06-16 00:52:33]

Patchset #2 (id:200001) has been deleted

[mcasas, 2015-06-16 05:50:02]

PTAL

https://codereview.chromium.org/1191443003/diff/90001/media/base/video_captur...
File media/base/video_capture_types.h (right):

https://codereview.chromium.org/1191443003/diff/90001/media/base/video_captur...
media/base/video_capture_types.h:106: bool operator==(const VideoCaptureParams&
other) const {
On 2015/06/15 19:08:58, tommi wrote:
> update this operator too?

Done.

https://codereview.chromium.org/1191443003/diff/90001/media/base/video_captur...
media/base/video_capture_types.h:119: bool use_native_gpu_memory_buffers;
On 2015/06/15 19:08:58, tommi wrote:
> the member variables in this class and above, don't follow the style guide. 
> Should they be a struct?

Done. And VideoCaptureFormat as well in l.67

[mcasas, 2015-06-16 17:28:06]

mcasas@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[mcasas, 2015-06-16 17:28:07]

dalecurtis@ can you PTAL?

(I think this CL is generic enough that
any owner can approve it and I see tommi@
is busy).

[mcasas, 2015-06-16 17:36:08]

mcasas@chromium.org changed reviewers:
+ tsepez@chromium.org

[mcasas, 2015-06-16 17:36:08]

tsepez@: tiny change in media_param_traits.cc plz

[DaleCurtis, 2015-06-16 17:51:18]

Why are you passing this value in a struct instead of using the command line
option directly where applicable?

[mcasas, 2015-06-16 18:09:19]

On 2015/06/16 17:51:18, DaleCurtis wrote:
> Why are you passing this value in a struct instead of using the command line
> option directly where applicable?

Because long(er) term the VideoCaptureDevice needs to be
hinted if the rest of the pipeline supports GpuMemoryBuffers,
and that suits better a flag in the VideoCaptureParams.
The command line flag is just a convenience to exercise 
this functionality separately from other CLs.

[DaleCurtis, 2015-06-16 18:26:08]

lgtm % change

https://codereview.chromium.org/1191443003/diff/220001/media/base/video_captu...
File media/base/video_capture_types.h (right):

https://codereview.chromium.org/1191443003/diff/220001/media/base/video_captu...
media/base/video_capture_types.h:12: 
Include build/build_config to ensure OS_XXX macros are defined at this point.

[mcasas, 2015-06-16 18:37:25]

Patchset #3 (id:240001) has been deleted

[Tom Sepez, 2015-06-16 18:47:12]

param traits LGTM

[mcasas, 2015-06-16 19:04:06]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2015-06-16 19:04:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/1191443003/#ps260001
(title: "Added #include "build/build_config.h"")

[commit-bot: I haz the power, 2015-06-16 19:06:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1191443003/260001

[commit-bot: I haz the power, 2015-06-16 20:14:43]

Committed patchset #3 (id:260001)

[commit-bot: I haz the power, 2015-06-16 20:15:46]

Patchset 3 (id:??) landed as
https://crrev.com/354e3e2d4a380bf463d683d853c27227729d15f0
Cr-Commit-Position: refs/heads/master@{#334674}

[mcasas, 2015-06-16 20:47:02]

sending a draft, please ignore.

https://codereview.chromium.org/1191443003/diff/220001/media/base/video_captu...
File media/base/video_capture_types.h (right):

https://codereview.chromium.org/1191443003/diff/220001/media/base/video_captu...
media/base/video_capture_types.h:12: 
On 2015/06/16 18:26:08, DaleCurtis wrote:
> Include build/build_config to ensure OS_XXX macros are defined at this point.

Done.