Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 1191433003: Fix -Wsign-compare errors in TF tests under GCC 4.9.2 (Closed)

Created:
5 years, 6 months ago by wingo
Modified:
5 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix -Wsign-compare errors in TF tests under GCC 4.9.2 R=jkummerow@chromium.org LOG=N BUG= Committed: https://crrev.com/9efb230d367b48873a52bd701b90a49276c1cef5 Cr-Commit-Position: refs/heads/master@{#29023}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M test/unittests/compiler/graph-reducer-unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/unittests/compiler/node-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
wingo
5 years, 6 months ago (2015-06-15 11:12:03 UTC) #1
Jakob Kummerow
lgtm
5 years, 6 months ago (2015-06-15 11:31:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1191433003/1
5 years, 6 months ago (2015-06-15 11:41:49 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-15 12:03:39 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 12:03:56 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9efb230d367b48873a52bd701b90a49276c1cef5
Cr-Commit-Position: refs/heads/master@{#29023}

Powered by Google App Engine
This is Rietveld 408576698