Include webrtc_logging_private.idl even when enable_webrtc=0

Include webrtc_logging_private.idl even when enable_webrtc=0

Unless you have an existing build with enable_webrtc=1 in place, chrome will fail to compile.

BUG=331550
TEST=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243764

[commit-bot: I haz the power, 2014-01-06 12:12:48]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[joi, 2014-01-06 12:13:18]

LGTM, thanks.


On Fri, Jan 3, 2014 at 7:21 PM, <davemoore@chromium.org> wrote:

> Reviewers: joi,
>
> Description:
> Include webrtc_logging_private.idl even when enable_webrtc=0
>
> Unless you have an existing build with enable_webrtc=1 in place, chrome
> will
> fail to compile.
>
> BUG=331550
> TEST=None
>
>
> Please review this at https://codereview.chromium.org/119143004/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+1, -1 lines):
>   M chrome/common/extensions/api/api.gyp
>
>
> Index: chrome/common/extensions/api/api.gyp
> diff --git a/chrome/common/extensions/api/api.gyp
> b/chrome/common/extensions/api/api.gyp
> index 0724879d8e7b65443c6ab60b654a06b6d03396f1..
> 8fc3167e9215c6975839e962aa33698ec5c7d2e5 100644
> --- a/chrome/common/extensions/api/api.gyp
> +++ b/chrome/common/extensions/api/api.gyp
> @@ -123,6 +123,7 @@
>                # WebRTC-specific bits and as such does not belong in
>                # the enable_webrtc=0 section below.
>                'webrtc_audio_private.idl',
> +              'webrtc_logging_private.idl',
>                'webstore_private.json',
>                'webview.json',
>                'windows.json',
> @@ -169,7 +170,6 @@
>                'cast_streaming_rtp_stream.idl',
>                'cast_streaming_session.idl',
>                'cast_streaming_udp_transport.idl',
> -              'webrtc_logging_private.idl',
>              ],
>            }],
>          ],
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Jói, 2014-01-06 12:16:29]

LGTM from right address this time.


On Fri, Jan 3, 2014 at 7:21 PM, <davemoore@chromium.org> wrote:

> Reviewers: joi,
>
> Description:
> Include webrtc_logging_private.idl even when enable_webrtc=0
>
> Unless you have an existing build with enable_webrtc=1 in place, chrome
> will
> fail to compile.
>
> BUG=331550
> TEST=None
>
>
> Please review this at https://codereview.chromium.org/119143004/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+1, -1 lines):
>   M chrome/common/extensions/api/api.gyp
>
>
> Index: chrome/common/extensions/api/api.gyp
> diff --git a/chrome/common/extensions/api/api.gyp
> b/chrome/common/extensions/api/api.gyp
> index 0724879d8e7b65443c6ab60b654a06b6d03396f1..
> 8fc3167e9215c6975839e962aa33698ec5c7d2e5 100644
> --- a/chrome/common/extensions/api/api.gyp
> +++ b/chrome/common/extensions/api/api.gyp
> @@ -123,6 +123,7 @@
>                # WebRTC-specific bits and as such does not belong in
>                # the enable_webrtc=0 section below.
>                'webrtc_audio_private.idl',
> +              'webrtc_logging_private.idl',
>                'webstore_private.json',
>                'webview.json',
>                'windows.json',
> @@ -169,7 +170,6 @@
>                'cast_streaming_rtp_stream.idl',
>                'cast_streaming_session.idl',
>                'cast_streaming_udp_transport.idl',
> -              'webrtc_logging_private.idl',
>              ],
>            }],
>          ],
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-01-06 12:19:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/davemoore@chromium.org/119143004/1

[commit-bot: I haz the power, 2014-01-06 12:37:57]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[DaveMoore, 2014-01-08 16:29:39]

asargent: OWNERS please?

[asargent_no_longer_on_chrome, 2014-01-08 22:35:28]

lgtm

[commit-bot: I haz the power, 2014-01-08 23:03:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/davemoore@chromium.org/119143004/1

[commit-bot: I haz the power, 2014-01-09 04:28:15]

Change committed as 243764