Start sending synthetic keyevents for enter and tab in Android IME

content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser;
 
 import android.app.Activity;
 import android.app.ActivityManager;
 import android.content.Context;
 import android.content.pm.ActivityInfo;
@@ skipping 1376 matching lines @@
      * @see View#dispatchKeyEventPreIme(KeyEvent)
      */
     public boolean dispatchKeyEventPreIme(KeyEvent event) {
         try {
             TraceEvent.begin();
             if (event.getKeyCode() == KeyEvent.KEYCODE_BACK && mImeAdapter.isActive()) {
                 mUnfocusOnNextSizeChanged = true;
             } else {
                 undoScrollFocusedEditableNodeIntoViewIfNeeded(false);
             }
-            mImeAdapter.dispatchKeyEventPreIme(event);
             return mContainerViewInternals.super_dispatchKeyEventPreIme(event);
         } finally {
             TraceEvent.end();
         }
     }
 
     /**
      * @see View#dispatchKeyEvent(KeyEvent)
      */
     public boolean dispatchKeyEvent(KeyEvent event) {
         if (mImeAdapter != null &&
                 !mImeAdapter.isNativeImeAdapterAttached() && mNativeContentViewCore != 0) {
             mImeAdapter.attach(nativeGetNativeImeAdapter(mNativeContentViewCore));
         }
         // The key handling logic is kind of confusing here.
         // The purpose of shouldOverrideKeyEvent() is to filter out some keys that is critical
         // to browser function but useless in renderer process (for example, the back button),
         // so the browser can still respond to these keys in a timely manner when the renderer
         // process is busy/blocked/busted. mImeAdapter.dispatchKeyEvent() forwards the key event
         // to the renderer process. If mImeAdapter is bypassed or is not interested to the event,
         // fall back to the default dispatcher to propagate the event to sub-views.
         return (!getContentViewClient().shouldOverrideKeyEvent(event)
-                && mImeAdapter.dispatchKeyEvent(event))
+                && (mKeyboardConnected && mImeAdapter.dispatchKeyEvent(event)))

[aurimas (slooooooooow), 2013/01/16 00:39:57]

Could we rewrite this return statement into a clearer way?

[Yusuf, 2013/01/16 08:07:57]

Done.

                 || mContainerViewInternals.super_dispatchKeyEvent(event);
     }
 
     /**
      * @see View#onHoverEvent(MotionEvent)
      * Mouse move events are sent on hover enter, hover move and hover exit.
      * They are sent on hover exit because sometimes it acts as both a hover
      * move and hover exit.
      */
     public boolean onHoverEvent(MotionEvent event) {
@@ skipping 1155 matching lines @@
     private native void nativeUpdateVSyncParameters(int nativeContentViewCoreImpl,
             long timebaseMicros, long intervalMicros);
 
     private native boolean nativePopulateBitmapFromCompositor(int nativeContentViewCoreImpl,
             Bitmap bitmap);
 
     private native void nativeSetSize(int nativeContentViewCoreImpl, int width, int height);
 
     private native boolean nativeIsRenderWidgetHostViewReady(int nativeContentViewCoreImpl);
 }