Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Unified Diff: components/invalidation/impl/BUILD.gn

Issue 1191393008: Introduce a layering in the invalidation component as public and impl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Explicitly forbid content to prevent future additions Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/invalidation/gcm_network_channel_unittest.cc ('k') | components/invalidation/impl/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/invalidation/impl/BUILD.gn
diff --git a/components/invalidation/BUILD.gn b/components/invalidation/impl/BUILD.gn
similarity index 88%
rename from components/invalidation/BUILD.gn
rename to components/invalidation/impl/BUILD.gn
index 7fa7b8777024203528a7210c48cedecd25cd0c55..f01269c64a2e7da4319950417bb73a3bc21e2140 100644
--- a/components/invalidation/BUILD.gn
+++ b/components/invalidation/impl/BUILD.gn
@@ -5,46 +5,29 @@ if (is_android) {
import("//build/config/android/rules.gni")
}
-static_library("invalidation") {
+static_library("impl") {
sources = [
- "ack_handle.cc",
- "ack_handle.h",
- "ack_handler.cc",
- "ack_handler.h",
- "invalidation.cc",
- "invalidation.h",
- "invalidation_handler.cc",
- "invalidation_handler.h",
"invalidation_logger.cc",
"invalidation_logger.h",
"invalidation_logger_observer.h",
"invalidation_prefs.cc",
"invalidation_prefs.h",
- "invalidation_service.h",
"invalidation_service_util.cc",
"invalidation_service_util.h",
"invalidation_state_tracker.cc",
"invalidation_state_tracker.h",
"invalidation_switches.cc",
"invalidation_switches.h",
- "invalidation_util.cc",
- "invalidation_util.h",
"invalidator.cc",
"invalidator.h",
"invalidator_registrar.cc",
"invalidator_registrar.h",
- "invalidator_state.cc",
- "invalidator_state.h",
"invalidator_storage.cc",
"invalidator_storage.h",
"mock_ack_handler.cc",
"mock_ack_handler.h",
- "object_id_invalidation_map.cc",
- "object_id_invalidation_map.h",
"profile_invalidation_provider.cc",
"profile_invalidation_provider.h",
- "single_object_invalidation_set.cc",
- "single_object_invalidation_set.h",
"unacked_invalidation_set.cc",
"unacked_invalidation_set.h",
]
@@ -78,23 +61,23 @@ static_library("invalidation") {
"ticl_settings_provider.h",
]
}
-
public_deps = [
- "//third_party/cacheinvalidation",
+ "//components/invalidation/public",
]
deps = [
"//base",
+ "//base:i18n",
+ "//base:prefs",
"//components/gcm_driver",
"//components/keyed_service/core",
"//components/pref_registry",
"//components/signin/core/browser",
"//google_apis",
"//jingle:notifier",
+ "//net:net",
# TODO(sync): Remove this (http://crbug.com/133352);
"//third_party/protobuf:protobuf_lite",
-
- # "//third_party/cacheinvalidation/src/google/cacheinvalidation:cacheinvalidation_proto_cpp",
]
if (is_android) {
@@ -111,7 +94,7 @@ static_library("invalidation") {
group("unittests") {
testonly = true
deps = [
- ":invalidation",
+ ":impl",
":test_support",
]
if (is_android) {
« no previous file with comments | « components/invalidation/gcm_network_channel_unittest.cc ('k') | components/invalidation/impl/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698